From: Liu Ying <Ying.Liu@freescale.com>
To: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, linux@arm.linux.org.uk,
kernel@pengutronix.de, airlied@linux.ie,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
p.zabel@pengutronix.de, mturquette@linaro.org,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 04/15] drm/dsi: Do not add DSI devices for the child nodes with input-port property
Date: Wed, 10 Dec 2014 16:37:17 +0800 [thread overview]
Message-ID: <1418200648-32656-5-git-send-email-Ying.Liu@freescale.com> (raw)
In-Reply-To: <1418200648-32656-1-git-send-email-Ying.Liu@freescale.com>
The MIPI DSI bus driver would try to add a DSI device for a host's every
child node which contains the reg property. Unfortunately, the existing
i.MX6Q/SDL MIPI DSI host device tree node's child nodes contain the reg
property, but the child nodes are ports pointing to dedicated CRTCs.
So, this patch phases out the child nodes with input-port property before
adding DSI devices for them and updates the MIPI DSI bus OF binding
documentation.
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt | 4 ++++
drivers/gpu/drm/drm_mipi_dsi.c | 5 +++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt b/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt
index 973c272..1a1d3c1 100644
--- a/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt
+++ b/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt
@@ -36,6 +36,10 @@ Peripherals are represented as child nodes of the DSI host's node. Properties
described here apply to all DSI peripherals, but individual bindings may want
to define additional, device-specific properties.
+Please, do not add the input-port property to the child nodes which represent
+peripherals. Otherwise, the peripherals would be omitted by the MIPI DSI bus
+driver.
+
Required properties:
- reg: The virtual channel number of a DSI peripheral. Must be in the range
from 0 to 3.
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index c0644bb..9adacfe 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -176,8 +176,9 @@ int mipi_dsi_host_register(struct mipi_dsi_host *host)
struct device_node *node;
for_each_available_child_of_node(host->dev->of_node, node) {
- /* skip nodes without reg property */
- if (!of_find_property(node, "reg", NULL))
+ /* skip nodes without reg property or with input-port property */
+ if (!of_find_property(node, "reg", NULL) ||
+ of_find_property(node, "input-port", NULL))
continue;
of_mipi_dsi_device_add(host, node);
}
--
2.1.0
next prev parent reply other threads:[~2014-12-10 8:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 8:37 [PATCH RFC 00/15] Add support for i.MX MIPI DSI DRM driver Liu Ying
[not found] ` <1418200648-32656-1-git-send-email-Ying.Liu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-12-10 8:37 ` [PATCH RFC 01/15] clk: divider: Correct parent clk round rate if no bestdiv is normally found Liu Ying
2014-12-10 8:37 ` [PATCH RFC 02/15] of: Add vendor prefix for Himax Technologies Inc Liu Ying
2014-12-10 8:37 ` [PATCH RFC 03/15] of: Add vendor prefix for Truly Semiconductors Limited Liu Ying
2014-12-10 8:37 ` Liu Ying [this message]
2014-12-10 12:21 ` [PATCH RFC 04/15] drm/dsi: Do not add DSI devices for the child nodes with input-port property Thierry Reding
2014-12-11 2:52 ` Liu Ying
2014-12-11 5:50 ` Liu Ying
2014-12-10 8:37 ` [PATCH RFC 05/15] ARM: dts: imx6qdl: Add input-port property to MIPI DSI node's CTRC child nodes Liu Ying
2014-12-10 8:37 ` [PATCH RFC 06/15] ARM: dts: imx6q: Add MIPI DSI remote end points for IPU2 DI0/1 end points Liu Ying
2014-12-10 8:37 ` [PATCH RFC 07/15] ARM: imx6q: Add GPR3 MIPI muxing control register field shift bits definition Liu Ying
2014-12-10 8:37 ` [PATCH RFC 08/15] ARM: imx6q: clk: Add the video_27m clock Liu Ying
2014-12-10 8:37 ` [PATCH RFC 09/15] drm: imx: Add MIPI DSI host controller driver Liu Ying
2014-12-10 13:16 ` Thierry Reding
2014-12-17 9:44 ` Liu Ying
2014-12-17 10:40 ` Russell King - ARM Linux
2014-12-18 2:46 ` Liu Ying
2014-12-10 8:37 ` [PATCH RFC 10/15] drm: panel: Add support for Himax HX8369A MIPI DSI panel Liu Ying
2014-12-10 14:03 ` Thierry Reding
2014-12-17 10:27 ` Liu Ying
2014-12-10 8:37 ` [PATCH RFC 11/15] ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller Liu Ying
2014-12-10 8:37 ` [PATCH RFC 12/15] ARM: dts: imx6qdl-sabresd: Add support for TRULY TFT480800-16-E MIPI DSI panel Liu Ying
2014-12-10 14:07 ` Thierry Reding
2014-12-17 10:35 ` Liu Ying
2014-12-10 8:37 ` [PATCH RFC 13/15] ARM: imx_v6_v7_defconfig: Cleanup for imx drm being moved out of staging Liu Ying
2014-12-10 8:37 ` [PATCH RFC 14/15] ARM: imx_v6_v7_defconfig: Add support for MIPI DSI host controller Liu Ying
2014-12-10 8:37 ` [PATCH RFC 15/15] ARM: imx_v6_v7_defconfig: Add support for Himax HX8369A panel Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418200648-32656-5-git-send-email-Ying.Liu@freescale.com \
--to=ying.liu@freescale.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).