From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yingjoe Chen Subject: Re: [PATCH 2/4] irqchip: mediatek: Add support for mt8173 Date: Wed, 10 Dec 2014 22:37:13 +0800 Message-ID: <1418222233.21309.17.camel@mtksdaap41> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com> <2545975.QDuBFbG7BN@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2545975.QDuBFbG7BN@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Eddie Huang , Matthias Brugger , Rob Herring , Jason Cooper , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Pawel Moll , Ian Campbell , Catalin Marinas , Mark Brown , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Robert Richter , Sascha Hauer , Kumar Gala , Olof Johansson , Thomas Gleixner , yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Arnd, On Wed, 2014-12-10 at 12:00 +0100, Arnd Bergmann wrote: > On Wednesday 10 December 2014 18:50:00 Eddie Huang wrote: > > From: Yingjoe Chen > > > > MT8173 intpol have 32 more irq pins, add support to it. > > > > Signed-off-by: Yingjoe Chen > > Signed-off-by: Eddie Huang > > > > How about adding a property for the number of irq pins and leave the > old compatible string in place? I don't think it would be good if > we have to update this driver for each new SoC that uses this > irqchip just to change one number. > > Arnd OK, I'll change to something like this in next version: --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt @@ -17,12 +17,17 @@ Required properties: use the same interrupt-cells format as GIC. - reg: Physical base address of the intpol registers and length of memory mapped region. +Optional properties: +- mediatek,intpol-number: The number of interrupts supported by intpol, + default 224 if omitted. + Example: sysirq: interrupt-controller@10200100 { compatible = "mediatek,mt6589-sysirq", "mediatek,mt6577-sysirq"; interrupt-controller; #interrupt-cells = <3>; interrupt-parent = <&gic>; reg = <0 0x10200100 0 0x1c>; + mediatek,intpol-number = <224>; }; Joe.C -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html