From: Joe Perches <joe@perches.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Yunzhi Li <lyz@rock-chips.com>,
heiko@sntech.de, jwerner@chromium.org, dianders@chromium.org,
olof@lixom.net, huangtao@rock-chips.com, zyw@rock-chips.com,
cf@rock-chips.com, linux-rockchip@lists.infradead.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY
Date: Wed, 10 Dec 2014 22:12:02 -0800 [thread overview]
Message-ID: <1418278322.18092.30.camel@perches.com> (raw)
In-Reply-To: <5489338C.1030109@ti.com>
On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote:
> On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote:
> > diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
[]
> > +/*
> > + * The higher 16-bit of this register is used for write protection
> > + * only if BIT(13 + 16) set to 1 the BIT(13) can be written.
> > + */
> > +#define SIDDQ_MSK BIT(13 + 16)
huh?
This #define looks _very_ odd.
Is this supposed to be a single bit 29 or
some range?
next prev parent reply other threads:[~2014-12-11 6:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 10:46 [PATCH v5 0/5] Patches to add support for Rockchip usb PHYs Yunzhi Li
2014-12-10 10:46 ` [PATCH v5 1/5] phy: add a driver for the Rockchip SoC internal USB2.0 PHY Yunzhi Li
2014-12-11 6:02 ` Kishon Vijay Abraham I
2014-12-11 6:12 ` Joe Perches [this message]
2014-12-11 6:27 ` Kishon Vijay Abraham I
[not found] ` <54893963.7060304-l0cyMroinI0@public.gmane.org>
2014-12-11 6:37 ` Joe Perches
[not found] ` <1418279847.18092.32.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2014-12-11 6:52 ` Yunzhi Li
[not found] ` <54893F26.5050304-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-11 7:06 ` Joe Perches
[not found] ` <1418281568.18092.34.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2014-12-11 7:16 ` Chris Zhong
[not found] ` <5489338C.1030109-l0cyMroinI0@public.gmane.org>
2014-12-11 7:44 ` Yunzhi Li
2014-12-11 8:36 ` Kishon Vijay Abraham I
[not found] ` <1418208371-18851-1-git-send-email-lyz-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-10 10:46 ` [PATCH v5 2/5] Documentation: bindings: add dt documentation for Rockchip usb PHY Yunzhi Li
2014-12-10 10:46 ` [PATCH v5 4/5] ARM: dts: rockchip: add rk3288 " Yunzhi Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418278322.18092.30.camel@perches.com \
--to=joe@perches.com \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jwerner@chromium.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lyz@rock-chips.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).