From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eddie Huang Subject: Re: [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile Date: Thu, 11 Dec 2014 20:47:06 +0800 Message-ID: <1418302026.1992.18.camel@mtksdaap41> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-4-git-send-email-eddie.huang@mediatek.com> <1418221662.21309.13.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matthias Brugger Cc: Yingjoe Chen , Rob Herring , Jason Cooper , srv_heupstream , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , Thomas Gleixner , Olof Johansson , Robert Richter , Mark Brown , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Sascha Hauer , YH Chen =?UTF-8?Q?=28=E9=99=B3=E6=98=B1=E8=B1=AA=29?= List-Id: devicetree@vger.kernel.org On Wed, 2014-12-10 at 15:50 +0100, Matthias Brugger wrote: > 2014-12-10 15:27 GMT+01:00 Yingjoe Chen : > > > > Hi, > > > > On Wed, 2014-12-10 at 18:50 +0800, Eddie Huang wrote: > > <...> > >> diff --git a/arch/arm64/boot/dts/mt8173-evb.dts b/arch/arm64/boot/dts/mt8173-evb.dts > >> new file mode 100644 > >> index 0000000..adf26dd > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/mt8173-evb.dts > > <...> > >> + timer { > >> + compatible = "arm,armv8-timer"; > >> + interrupt-parent = <&gic>; > >> + interrupts = <1 13 0x8>, > >> + <1 14 0x8>, > >> + <1 11 0x8>, > >> + <1 10 0x8>; > >> + clock-frequency = <13000000>; > > > > I believe our firmware doesn't need this line. Please remove it. > > The point here would be to know if you need to enable a special timer > from the mtk-timer block to get the arch timer working. > In any case, you will need some sort of timer. This dts does not > describe the mtk-timer (may in the mt8173 it does not exist) but > defines the clocks clk26m and clk32k. So if you don't use the > mtk-timer, please remove the clocks as there isn't a block using them. > MT8173 has two timer set: CPUGPT and APBGPT, and use CPUGPT to enable arch_timer. Previous series only have APBGPT. MT8173 still need enable CPUGPT to get arch timer working, we put this in loader, and transparent to kernel. So I will remove clk26m and clk32k in next version. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html