From: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Vladimir Murzin <vladimir.murzin@arm.com>,
Russell King <linux@arm.linux.org.uk>,
srv_heupstream@mediatek.com, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, alan.cheng@mediatek.com,
maoguang.meng@mediatek.com,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
toby.liu@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
dandan.he@mediatek.com, linux-arm-kernel@lists.infradead.org,
Hongzhou Yang <hongzhou.yang@mediatek.com>
Subject: Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.
Date: Wed, 17 Dec 2014 17:09:25 +0800 [thread overview]
Message-ID: <1418807365.6443.17.camel@mtksdaap41> (raw)
In-Reply-To: <1418772873-19747-5-git-send-email-hongzhou.yang@mediatek.com>
On Wed, 2014-12-17 at 07:34 +0800, Hongzhou Yang wrote:
> From: Maoguang Meng <maoguang.meng@mediatek.com>
>
> MTK SoC support external interrupt(EINT) from most SoC pins.
> Add EINT support to pinctrl driver.
>
> Signed-off-by: Maoguang Meng <maoguang.meng@mediatek.com>
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
Hi Linus,
This patch add EINT support to the pinctrl driver. We've surveyed
GPIOLIB_IRQCHIP, but we didn't use it because:
- Not every GPIO pin support interrupt.
- EINT use a different numbering to GPIO. eg, from the mt8135 table,
GPIO29 is EINT158. It is more nature & efficient to use EINT number as
hwirq.
+ MTK_EINT_FUNCTION(2, 158),
+ MTK_FUNCTION(0, "GPIO29"),
Joe.C
next prev parent reply other threads:[~2014-12-17 9:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 23:34 [PATCH v4 0/5] Add Mediatek SoC Pinctrl/GPIO/EINT driver for MT8135 Hongzhou Yang
2014-12-16 23:34 ` [PATCH v4 1/5] ARM: mediatek: Add config options for mediatek SoCs Hongzhou Yang
[not found] ` <1418772873-19747-2-git-send-email-hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-01-13 9:43 ` Linus Walleij
[not found] ` <CACRpkda2pHpjMAsEeuEebShQnbqf5knfNbEGtSHLN=o18HC5nQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-14 2:33 ` Yingjoe Chen
2014-12-16 23:34 ` [PATCH v4 2/5] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx Hongzhou Yang
[not found] ` <1418772873-19747-3-git-send-email-hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-01-13 10:11 ` Linus Walleij
2015-01-20 15:46 ` Matthias Brugger
2014-12-16 23:34 ` [PATCH v4 3/5] ARM: mediatek: Add Pinctrl/GPIO driver for mt8135 Hongzhou Yang
2014-12-16 23:34 ` [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver Hongzhou Yang
2014-12-17 9:09 ` Yingjoe Chen [this message]
2015-01-06 9:16 ` Yingjoe Chen
2015-01-13 13:24 ` Linus Walleij
[not found] ` <CACRpkdb2KJbjzFgTmDvHSw7jNAExxVtU3y4_fgyn6J8hcW5OrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-14 2:32 ` Yingjoe Chen
2015-01-15 17:30 ` Linus Walleij
[not found] ` <CACRpkdY7_A_rORDvDrGtV0aa6mJGj=Sr-k=KVGu_=0et-gNpiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-16 2:50 ` Yingjoe Chen
2015-01-19 10:35 ` Linus Walleij
2014-12-16 23:34 ` [PATCH v4 5/5] ARM: dts: mt8135: Add pinctrl/GPIO/EINT node for mt8135 Hongzhou Yang
2015-01-20 15:53 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418807365.6443.17.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=alan.cheng@mediatek.com \
--cc=ashwin.chaugule@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=dandan.he@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=hongzhou.yang@mediatek.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maoguang.meng@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=toby.liu@mediatek.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).