devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jianqun Xu <jay.xu@rock-chips.com>
To: lgirdwood@gmail.com, heiko@sntech.de, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.de, sonnyrao@chromium.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Jianqun Xu <jay.xu@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ASoC: rockchip: i2s: fix error defination of transmit data level
Date: Wed, 24 Dec 2014 17:37:00 +0800	[thread overview]
Message-ID: <1419413822-11539-2-git-send-email-jay.xu@rock-chips.com> (raw)
In-Reply-To: <1419413822-11539-1-git-send-email-jay.xu@rock-chips.com>

According to description about "Transmit Data Level",

This bit field controls the level at which a DMA request
is made by the transmit logic.

It is equal to the watermark level.

That is, the dma_tx_req signal is generated when the number
of valid data entries in the TXFIFO
(TXFIFO0 if CSR=00
 TXFIFO1 if CSR=01
 TXFIFO2 if CSR=10
 TXFIFO3 if CSR=11)
is equal to or below this field value.

Different to receive data level, transmit data level does not need
to "-1".

Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
changes since v1:
- none

 sound/soc/rockchip/rockchip_i2s.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/rockchip/rockchip_i2s.h b/sound/soc/rockchip/rockchip_i2s.h
index 89a5d8b..93f456f 100644
--- a/sound/soc/rockchip/rockchip_i2s.h
+++ b/sound/soc/rockchip/rockchip_i2s.h
@@ -127,7 +127,7 @@
 #define I2S_DMACR_TDE_DISABLE	(0 << I2S_DMACR_TDE_SHIFT)
 #define I2S_DMACR_TDE_ENABLE	(1 << I2S_DMACR_TDE_SHIFT)
 #define I2S_DMACR_TDL_SHIFT	0
-#define I2S_DMACR_TDL(x)	((x - 1) << I2S_DMACR_TDL_SHIFT)
+#define I2S_DMACR_TDL(x)	((x) << I2S_DMACR_TDL_SHIFT)
 #define I2S_DMACR_TDL_MASK	(0x1f << I2S_DMACR_TDL_SHIFT)
 
 /*
-- 
1.9.1

  reply	other threads:[~2014-12-24  9:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23  9:08 [PATCH 0/2] ASoC: rockchip: i2s: fix TDL and RDL to 16 bits Jianqun Xu
2014-12-23  9:08 ` [PATCH 1/2] ASoC: rockchip: i2s: fix error defination of transmit data level Jianqun Xu
     [not found] ` <1419325709-15374-1-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-23  9:08   ` [PATCH 2/2] ASoC: rockchip: i2s: set TDL and RDL to 16 bits Jianqun Xu
2014-12-23 23:06     ` [alsa-devel] " Dylan Reid
     [not found]       ` <CAEUnVG79MOHUufRnJVe98ZTC4vouUNAEWtPsryEKWLc+Qpdjuw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-24  0:36         ` Jianqun
2014-12-24  9:36   ` [PATCH v2 0/3] ASoC: rockchip: i2s: fix watermark to 16 and maxburst to 4 Jianqun Xu
2014-12-24  9:37     ` Jianqun Xu [this message]
2014-12-24  9:37     ` [PATCH v2 2/3] ASoC: rockchip: i2s: set TDL and RDL to 16 samples Jianqun Xu
     [not found]     ` <1419413822-11539-1-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-24  9:37       ` [PATCH v2 3/3] ASoC: rockchip: i2s: fix maxburst of dma data to 4 Jianqun Xu
2014-12-24 12:43       ` [PATCH v2 0/3] ASoC: rockchip: i2s: fix watermark to 16 and maxburst " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419413822-11539-2-git-send-email-jay.xu@rock-chips.com \
    --to=jay.xu@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=perex@perex.cz \
    --cc=sonnyrao@chromium.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).