From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3819FC4338F for ; Fri, 13 Aug 2021 15:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2011E60FBF for ; Fri, 13 Aug 2021 15:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240997AbhHMPqr (ORCPT ); Fri, 13 Aug 2021 11:46:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241165AbhHMPqq (ORCPT ); Fri, 13 Aug 2021 11:46:46 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C082C0617AD for ; Fri, 13 Aug 2021 08:46:19 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id w21-20020a7bc1150000b02902e69ba66ce6so7202894wmi.1 for ; Fri, 13 Aug 2021 08:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RGqYP/BN1Qfj8+Nm3t3v0K4q1x+QcZ7RN1PrsmUqieY=; b=Pvtg9Vmhd42TvM0kpWNs+0odqdTyMN5J7ijyasOeD+aIcPMwBs0qOHAtN2uuHtZw7G fCKTXtB0gafDUd2da+Ui9HETXJQnUp1QJ1GhOmfWw0QQq01ssbZmNWqddpilRtNoL3JP /GYbY1YCnaCa3HOg+hh1gT1KNsrpV4qX5ytivj8rGNcK0u5FAlNEobB8ooNE6UA7XVyX +ACLzUmfuFV6O7rNzoBXWEd0zO5DjqDZg/qBpOj0Ibi/E0Zr1JDoq5TSqyfQlgzr7MSI Rjk+m9dJEpfdE2Zq7rOfH66u4dj9LG/Mjjco/VxLSn+4Ze9LPsJrMx30eK5MIhahUzhE uXGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RGqYP/BN1Qfj8+Nm3t3v0K4q1x+QcZ7RN1PrsmUqieY=; b=lj7Or7se8wJUYZZPAvNjtt46LQxAiNwmEBhb/dq+JJHITxoj+qyJoDZsTPEJNklS11 0RWBHD/ImqCEd0MpHD3SrHyRO3zZEeI6NvOJT5NtPSEb2dO6Ywce2+WHjkJSyQzd4Zeb 3aUC3w+ty+XpcVe+nWAzVxzjH8BhIASLneBYH1Coq+X2JD22RkBUQZehJr1pgbFOG16F f+cNqqRqWDPorIAw0xe1gInrcEamXj5vaNiV50g8ij71EY3xA7EYmadO3HpQUkH7c3I+ FuMoaOscTf36dn266A+xFyzTnlRQkd0fVYH9/iA5R5chQVvfgCJaydIzHLE7uK7esdmN CdVw== X-Gm-Message-State: AOAM531Mh74E7YzLMJoEEiYwTVSjZ7TjPlXkzViaYs2bHA7c4dyStbDW pa25vwwzTfYda34isRU2WLZ7jg== X-Google-Smtp-Source: ABdhPJyfOCUjMkXHY+NPlZyvCpNVgUdfJ4jJ5vMEbOB2l5W8H8w6JCWMnJ9DhY0TXdEY/B3zvted+Q== X-Received: by 2002:a1c:2905:: with SMTP id p5mr1152613wmp.146.1628869577924; Fri, 13 Aug 2021 08:46:17 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:5df3:d0eb:3945:640d? ([2a01:e34:ed2f:f020:5df3:d0eb:3945:640d]) by smtp.googlemail.com with ESMTPSA id y21sm1791206wma.38.2021.08.13.08.46.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Aug 2021 08:46:17 -0700 (PDT) Subject: Re: [PATCH v3] arm64: dts: rockchip: add thermal fan control to rockpro64 To: Peter Geis Cc: Robin Murphy , Rob Herring , Heiko Stuebner , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List References: <20210730151727.729822-1-pgwipeout@gmail.com> <893701da-ea17-00ab-5e31-c745051ac9b9@arm.com> <2b1050f2-0311-1871-820a-f876218894bc@linaro.org> From: Daniel Lezcano Message-ID: <141e29aa-d21d-31b8-9a81-015dcd63d24d@linaro.org> Date: Fri, 13 Aug 2021 17:46:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/08/2021 17:10, Peter Geis wrote: > On Fri, Aug 13, 2021 at 10:54 AM Daniel Lezcano > wrote: >> >> >> Hi Robin, >> >> >> On 13/08/2021 15:51, Robin Murphy wrote: >>> On 2021-08-13 13:59, Daniel Lezcano wrote: >>>> On 30/07/2021 17:17, Peter Geis wrote: >>>>> The rockpro64 had a fan node since >>>>> commit 5882d65c1691 ("arm64: dts: rockchip: Add PWM fan for RockPro64") >>>>> however it was never tied into the thermal driver for automatic control. >>>>> >>>>> Add the links to the thermal node to permit the kernel to handle this >>>>> automatically. >>>>> Borrowed from the (rk3399-khadas-edge.dtsi). >>>>> >>>>> Signed-off-by: Peter Geis >> >> [ ... ] >> >>>>> +&cpu_thermal { >>>>> + trips { >>>>> + cpu_warm: cpu_warm { >>>>> + temperature = <55000>; >>>>> + hysteresis = <2000>; >>>>> + type = "active"; >>>>> + }; >>>>> + >>>>> + cpu_hot: cpu_hot { >>>>> + temperature = <65000>; >>>>> + hysteresis = <2000>; >>>>> + type = "active"; >>>>> + }; >>>>> + }; >>>>> + >>>> >>>> Why two trip points ? >>>> >>>> Why not one functioning temperature and no lower / upper limits for the >>>> cooling maps ? >>> >>> Certainly when I first did this for NanoPC-T4, IIRC it was to avoid the >>> fan ramping up too eagerly, since level 1 for my fan is effectively >>> silent but still cools enough to let a moderate load eventually settle >>> to a steady state below the second trip. > > That's the same issue I had on the rockpro64. > >> >> Thanks for your answer. >> >> What would be the governor for this setup ? >> > > The default governor when using arm64_defconfig is step_wise. Ok, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog