[PATCH 1/2] Add sysirq device node for mt6592, also correct the timer interrupt.

[PATCH 1/2] Add sysirq device node for mt6592, also correct the timer interrupt.

[Howard Chen]

Signed-off-by: Howard Chen <howard.chen@linaro.org>
---
 arch/arm/boot/dts/mt6592.dtsi | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/mt6592.dtsi b/arch/arm/boot/dts/mt6592.dtsi
index 31e5a09..1db453f 100644
--- a/arch/arm/boot/dts/mt6592.dtsi
+++ b/arch/arm/boot/dts/mt6592.dtsi
@@ -18,7 +18,7 @@
 
 / {
 	compatible = "mediatek,mt6592";
-	interrupt-parent = <&gic>;
+	interrupt-parent = <&sysirq>;
 
 	cpus {
 		#address-cells = <1>;
@@ -78,21 +78,34 @@
 		#clock-cells = <0>;
 	};
 
+	uart_clk: uart_clk {
+		compatible = "fixed-clock";
+		clock-frequency = <26000000>;
+		#clock-cells = <0>;
+	};
+
 	timer: timer@10008000 {
 		compatible = "mediatek,mt6577-timer";
 		reg = <0x10008000 0x80>;
-		interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_LOW>;
 		clocks = <&system_clk>, <&rtc_clk>;
 		clock-names = "system-clk", "rtc-clk";
 	};
 
+	sysirq: interrupt-controller@10200220 {
+		compatible = "mediatek,mt6592-sysirq", "mediatek,mt6577-sysirq";
+		interrupt-controller;
+		#interrupt-cells = <3>;
+		interrupt-parent = <&gic>;
+		reg = <0x10200220 0x1c>;
+	};
+
 	gic: interrupt-controller@10211000 {
 		compatible = "arm,cortex-a7-gic";
 		interrupt-controller;
 		#interrupt-cells = <3>;
+		interrupt-parent = <&gic>;
 		reg = <0x10211000 0x1000>,
 		      <0x10212000 0x1000>;
 	};
-
 };
-
-- 
1.9.1

[PATCH 2/2] dt-bindings: add mt6592 compatible string for mediatek sysirq

[Howard Chen]

Signed-off-by: Howard Chen <howard.chen-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt
index d680b07..4cd6f7b 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt
@@ -7,6 +7,7 @@ Required properties:
 - compatible: should be one of:
 	"mediatek,mt8135-sysirq"
 	"mediatek,mt8127-sysirq"
+	"mediatek,mt6592-sysirq"
 	"mediatek,mt6589-sysirq"
 	"mediatek,mt6582-sysirq"
 	"mediatek,mt6577-sysirq"
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] Add sysirq device node for mt6592, also correct the timer interrupt.

[Matthias Brugger]

Hi Howard,

2015-01-06 9:42 GMT+01:00 Howard Chen <howard.chen@linaro.org>:
> Signed-off-by: Howard Chen <howard.chen@linaro.org>
> ---
>  arch/arm/boot/dts/mt6592.dtsi | 21 +++++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)

Please use in the subject "ARM: mediatek: " prefix and please add a
commit message to your patch. From my point of view it's OK if you
explain in the commit message why we can/should change the timer
interrupt, please do so.

>
> diff --git a/arch/arm/boot/dts/mt6592.dtsi b/arch/arm/boot/dts/mt6592.dtsi
> index 31e5a09..1db453f 100644
> --- a/arch/arm/boot/dts/mt6592.dtsi
> +++ b/arch/arm/boot/dts/mt6592.dtsi
> @@ -18,7 +18,7 @@
>
>  / {
>         compatible = "mediatek,mt6592";
> -       interrupt-parent = <&gic>;
> +       interrupt-parent = <&sysirq>;
>
>         cpus {
>                 #address-cells = <1>;
> @@ -78,21 +78,34 @@
>                 #clock-cells = <0>;
>         };
>
> +       uart_clk: uart_clk {
> +               compatible = "fixed-clock";
> +               clock-frequency = <26000000>;
> +               #clock-cells = <0>;
> +       };
> +

Please delete the uart clock, it has nothing to do with the sysirq in
the first place.

Thanks,
Matthias

>         timer: timer@10008000 {
>                 compatible = "mediatek,mt6577-timer";
>                 reg = <0x10008000 0x80>;
> -               interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> +               interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_LOW>;
>                 clocks = <&system_clk>, <&rtc_clk>;
>                 clock-names = "system-clk", "rtc-clk";
>         };
>
> +       sysirq: interrupt-controller@10200220 {
> +               compatible = "mediatek,mt6592-sysirq", "mediatek,mt6577-sysirq";
> +               interrupt-controller;
> +               #interrupt-cells = <3>;
> +               interrupt-parent = <&gic>;
> +               reg = <0x10200220 0x1c>;
> +       };
> +
>         gic: interrupt-controller@10211000 {
>                 compatible = "arm,cortex-a7-gic";
>                 interrupt-controller;
>                 #interrupt-cells = <3>;
> +               interrupt-parent = <&gic>;
>                 reg = <0x10211000 0x1000>,
>                       <0x10212000 0x1000>;
>         };
> -
>  };
> -
> --
> 1.9.1
>



-- 
motzblog.wordpress.com