From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Liao Subject: Re: [PATCH v3 4/4] dts: mediatek: Enable clock support for Mediatek MT8135. Date: Thu, 8 Jan 2015 10:34:46 +0800 Message-ID: <1420684486.27952.23.camel@mtksdaap41> References: <1420601123-25859-1-git-send-email-jamesjj.liao@mediatek.com> <1420601123-25859-5-git-send-email-jamesjj.liao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Matthias Brugger Cc: Mark Rutland , Ashwin Chaugule , Vladimir Murzin , Mike Turquette , Pawel Moll , srv_heupstream , Ian Campbell , Catalin Marinas , "linux-kernel@vger.kernel.org" , HenryC Chen , "Joe.C" , "devicetree@vger.kernel.org" , Rob Herring , Sascha Hauer , Kumar Gala , jamesjj.liao@mediatek.com, Russell King , huang eddie , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hi Matthias, On Wed, 2015-01-07 at 17:25 +0100, Matthias Brugger wrote: > > + > > + clk_null: clk_null { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <0>; > > + }; > > + > > + clk26m: clk26m { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <26000000>; > > + }; > > + > > + rtc32k: rtc32k { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <32000>; > > + }; > > Why do you add this clocks here? > This clocks are not represented by the clock tree? If so, what are the > consumers of this clocks? These clocks are currently used in clk-mt8135.c to be root clocks, which represent clocks outside SoC and can't be controlled by MT8135. Best regards, James