* [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
@ 2015-01-15 1:08 Kevin Hilman
2015-01-20 9:19 ` Sjoerd Simons
2015-01-21 2:54 ` Joonyoung Shim
0 siblings, 2 replies; 4+ messages in thread
From: Kevin Hilman @ 2015-01-15 1:08 UTC (permalink / raw)
To: Kukjin Kim, linux-samsung-soc
Cc: linaro-kernel, Javier Martinez Canillas, Sjoerd Simons,
Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, open list:OPEN FIRMWARE AND...,
moderated list:ARM PORT, open list
From: Kevin Hilman <khilman@linaro.org>
The odroid-xu3 has 4 INA231 current sensors on board which can be
accessed from the Linux via the hwmon interface.
There is one sensor for each of these power rails:
- A15 cluster: VDD_ARM
- A7 cluster: VDD_KFC
- GPU: VDD_G3D
- memory: VDD_MEM
In addition to adding the sensors, LDO26 from the PMIC needs to be
enabled because it's powering these sensor.
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
v2: use "ti,ina231" as compatible string.
Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index c29123c0734d..50353d023225 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -174,6 +174,13 @@
regulator-always-on;
};
+ ldo26_reg: LDO26 {
+ regulator-name = "vdd_ldo26";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-always-on;
+ };
+
buck1_reg: BUCK1 {
regulator-name = "vdd_mif";
regulator-min-microvolt = <800000>;
@@ -257,6 +264,38 @@
};
};
+ i2c_0: i2c@12C60000 {
+ status = "okay";
+
+ /* A15 cluster: VDD_ARM */
+ ina231@40 {
+ compatible = "ti,ina231";
+ reg = <0x40>;
+ shunt-resistor = <10000>;
+ };
+
+ /* memory: VDD_MEM */
+ ina231@41 {
+ compatible = "ti,ina231";
+ reg = <0x41>;
+ shunt-resistor = <10000>;
+ };
+
+ /* GPU: VDD_G3D */
+ ina231@44 {
+ compatible = "ti,ina231";
+ reg = <0x44>;
+ shunt-resistor = <10000>;
+ };
+
+ /* A7 cluster: VDD_KFC */
+ ina231@45 {
+ compatible = "ti,ina231";
+ reg = <0x45>;
+ shunt-resistor = <10000>;
+ };
+ };
+
i2c_2: i2c@12C80000 {
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <66000>;
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
2015-01-15 1:08 [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors Kevin Hilman
@ 2015-01-20 9:19 ` Sjoerd Simons
2015-01-21 2:54 ` Joonyoung Shim
1 sibling, 0 replies; 4+ messages in thread
From: Sjoerd Simons @ 2015-01-20 9:19 UTC (permalink / raw)
To: Kevin Hilman
Cc: Kukjin Kim, linux-samsung-soc, linaro-kernel,
Javier Martinez Canillas, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Kukjin Kim,
open list:OPEN FIRMWARE AND..., moderated list:ARM PORT,
open list
[-- Attachment #1: Type: text/plain, Size: 2598 bytes --]
On Wed, 2015-01-14 at 17:08 -0800, Kevin Hilman wrote:
> From: Kevin Hilman <khilman@linaro.org>
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
I haven't tested whether the sensor values are correct, but based on the
schematics & the hardkernel dts this describes the hardware correctly.
Reviewed-By: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> v2: use "ti,ina231" as compatible string.
>
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..50353d023225 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -174,6 +174,13 @@
> regulator-always-on;
> };
>
> + ldo26_reg: LDO26 {
> + regulator-name = "vdd_ldo26";
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-always-on;
> + };
> +
> buck1_reg: BUCK1 {
> regulator-name = "vdd_mif";
> regulator-min-microvolt = <800000>;
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c@12C60000 {
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina231@40 {
> + compatible = "ti,ina231";
> + reg = <0x40>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* memory: VDD_MEM */
> + ina231@41 {
> + compatible = "ti,ina231";
> + reg = <0x41>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* GPU: VDD_G3D */
> + ina231@44 {
> + compatible = "ti,ina231";
> + reg = <0x44>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* A7 cluster: VDD_KFC */
> + ina231@45 {
> + compatible = "ti,ina231";
> + reg = <0x45>;
> + shunt-resistor = <10000>;
> + };
> + };
> +
> i2c_2: i2c@12C80000 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <66000>;
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
2015-01-15 1:08 [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors Kevin Hilman
2015-01-20 9:19 ` Sjoerd Simons
@ 2015-01-21 2:54 ` Joonyoung Shim
2015-01-22 19:47 ` Kevin Hilman
1 sibling, 1 reply; 4+ messages in thread
From: Joonyoung Shim @ 2015-01-21 2:54 UTC (permalink / raw)
To: Kevin Hilman, Kukjin Kim, linux-samsung-soc
Cc: linaro-kernel, Javier Martinez Canillas, Sjoerd Simons,
Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Kukjin Kim, open list:OPEN FIRMWARE AND...,
moderated list:ARM PORT, open list
Hi Kevin,
On 01/15/2015 10:08 AM, Kevin Hilman wrote:
> From: Kevin Hilman <khilman@linaro.org>
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> v2: use "ti,ina231" as compatible string.
>
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..50353d023225 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -174,6 +174,13 @@
> regulator-always-on;
> };
>
> + ldo26_reg: LDO26 {
> + regulator-name = "vdd_ldo26";
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-always-on;
> + };
> +
> buck1_reg: BUCK1 {
> regulator-name = "vdd_mif";
> regulator-min-microvolt = <800000>;
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c@12C60000 {
It's ok but IMHO it can split using label reference, e.g.
&i2c_0 {
...
};
Thanks.
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina231@40 {
> + compatible = "ti,ina231";
> + reg = <0x40>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* memory: VDD_MEM */
> + ina231@41 {
> + compatible = "ti,ina231";
> + reg = <0x41>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* GPU: VDD_G3D */
> + ina231@44 {
> + compatible = "ti,ina231";
> + reg = <0x44>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* A7 cluster: VDD_KFC */
> + ina231@45 {
> + compatible = "ti,ina231";
> + reg = <0x45>;
> + shunt-resistor = <10000>;
> + };
> + };
> +
> i2c_2: i2c@12C80000 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <66000>;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
2015-01-21 2:54 ` Joonyoung Shim
@ 2015-01-22 19:47 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2015-01-22 19:47 UTC (permalink / raw)
To: Joonyoung Shim
Cc: Kukjin Kim, linux-samsung-soc, linaro-kernel,
Javier Martinez Canillas, Sjoerd Simons, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Kukjin Kim,
open list:OPEN FIRMWARE AND..., moderated list:ARM PORT,
open list
Joonyoung Shim <jy0922.shim@samsung.com> writes:
> Hi Kevin,
>
> On 01/15/2015 10:08 AM, Kevin Hilman wrote:
>> From: Kevin Hilman <khilman@linaro.org>
>>
>> The odroid-xu3 has 4 INA231 current sensors on board which can be
>> accessed from the Linux via the hwmon interface.
>>
>> There is one sensor for each of these power rails:
>>
>> - A15 cluster: VDD_ARM
>> - A7 cluster: VDD_KFC
>> - GPU: VDD_G3D
>> - memory: VDD_MEM
>>
>> In addition to adding the sensors, LDO26 from the PMIC needs to be
>> enabled because it's powering these sensor.
>>
>> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>> ---
>> v2: use "ti,ina231" as compatible string.
>>
>> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>>
>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index c29123c0734d..50353d023225 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -174,6 +174,13 @@
>> regulator-always-on;
>> };
>>
>> + ldo26_reg: LDO26 {
>> + regulator-name = "vdd_ldo26";
>> + regulator-min-microvolt = <3000000>;
>> + regulator-max-microvolt = <3000000>;
>> + regulator-always-on;
>> + };
>> +
>> buck1_reg: BUCK1 {
>> regulator-name = "vdd_mif";
>> regulator-min-microvolt = <800000>;
>> @@ -257,6 +264,38 @@
>> };
>> };
>>
>> + i2c_0: i2c@12C60000 {
>
> It's ok but IMHO it can split using label reference, e.g.
>
> &i2c_0 {
> ...
> };
Yes, you're right. I'll spin a v3.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-22 19:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 1:08 [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors Kevin Hilman
2015-01-20 9:19 ` Sjoerd Simons
2015-01-21 2:54 ` Joonyoung Shim
2015-01-22 19:47 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).