From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Ribalda Delgado Subject: [PATCH 4/8] gpio-mm-lantiq: Use of_propery_read_u16 Date: Sun, 18 Jan 2015 12:39:29 +0100 Message-ID: <1421581173-28416-5-git-send-email-ricardo.ribalda@gmail.com> References: <1421581173-28416-1-git-send-email-ricardo.ribalda@gmail.com> Return-path: In-Reply-To: <1421581173-28416-1-git-send-email-ricardo.ribalda@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado , Linus Walleij , Alexandre Courbot , Grant Likely , Rob Herring , John Crispin , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Instead of parsing manually the shadow content, use the much simpler helper of_property_read_u16. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Grant Likely Cc: Rob Herring Cc: John Crispin Cc: devicetree@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- drivers/gpio/gpio-mm-lantiq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c index 7d55161..b511a6b 100644 --- a/drivers/gpio/gpio-mm-lantiq.c +++ b/drivers/gpio/gpio-mm-lantiq.c @@ -105,7 +105,6 @@ static void ltq_mm_save_regs(struct of_mm_gpio_chip *mm_gc) static int ltq_mm_probe(struct platform_device *pdev) { struct ltq_mm *chip; - const __be32 *shadow; chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL); if (!chip) @@ -117,9 +116,8 @@ static int ltq_mm_probe(struct platform_device *pdev) chip->mmchip.save_regs = ltq_mm_save_regs; /* store the shadow value if one was passed by the devicetree */ - shadow = of_get_property(pdev->dev.of_node, "lantiq,shadow", NULL); - if (shadow) - chip->shadow = be32_to_cpu(*shadow); + of_property_read_u16(pdev->dev.of_node, "lantiq,shadow", + &chip->shadow); return of_mm_gpiochip_add(pdev->dev.of_node, &chip->mmchip); } -- 2.1.4