Re: [PATCH v3 1/4] clk: dts: mediatek: add Mediatek MT8135 clock bindings

[James Liao <jamesjj.liao@mediatek.com>]

On Mon, 2015-01-19 at 07:35 -0800, Mike Turquette wrote:
> Quoting James Liao (2015-01-06 19:25:20)
> > +Example: I2C controller node that consumes the clock generated by the clock
> > +  controller (refer to the standard clock bindings for information about
> > +  "clocks" and "clock-names" properties):
> > +
> > +       i2c0: i2c@1100d000 {
> > +               compatible = "mediatek,mt8135-i2c", "mediatek,mt6589-i2c";
> > +               reg = <0 0x1100d000 0 0x70>, <0 0x11000300 0 0x80>;
> > +               interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
> > +               clock-div = <16>;
> > +               clocks = <&pericfg PERI_I2C0_CK>, <&pericfg PERI_AP_DMA_CK>;
> > +               clock-names = "main", "dma";
> > +       };
> 
> Hello,
> 
> Patch looks good to me overall. One suggestion for the next version is
> that your example above include a node for the clock controller itself,
> followed by the i2c controller example above.

OK, I'll add pericfg in next patch.


Best regards,
James