devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Murali Karicheri <m-karicheri2@ti.com>
To: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, iommu@lists.linux-foundation.org
Cc: Murali Karicheri <m-karicheri2@ti.com>
Subject: [PATCH v4 6/6] arm: dma-mapping: updates to limit dma_mask and iommu mapping size
Date: Fri, 23 Jan 2015 17:32:39 -0500	[thread overview]
Message-ID: <1422052359-12384-7-git-send-email-m-karicheri2@ti.com> (raw)
In-Reply-To: <1422052359-12384-1-git-send-email-m-karicheri2@ti.com>

Limit the dma_mask to minimum of dma_mask and dma_base + size - 1.

Also arm_iommu_create_mapping() has size parameter of size_t and
arm_setup_iommu_dma_ops() can take a value higher than that. So
limit the size to SIZE_MAX.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 arch/arm/mm/dma-mapping.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 7864797..a1f9030 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -2004,6 +2004,13 @@ static bool arm_setup_iommu_dma_ops(struct device *dev, u64 dma_base, u64 size,
 	if (!iommu)
 		return false;
 
+	/*
+	 * currently arm_iommu_create_mapping() takes a max of size_t
+	 * for size param. So check this limit for now.
+	 */
+	if (size > SIZE_MAX)
+		return false;
+
 	mapping = arm_iommu_create_mapping(dev->bus, dma_base, size);
 	if (IS_ERR(mapping)) {
 		pr_warn("Failed to create %llu-byte IOMMU mapping for device %s\n",
@@ -2053,6 +2060,9 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
 {
 	struct dma_map_ops *dma_ops;
 
+	/* limit dma_mask to the lower of the two values */
+	*dev->dma_mask = min((*dev->dma_mask), (dma_base + size - 1));
+
 	dev->archdata.dma_coherent = coherent;
 	if (arm_setup_iommu_dma_ops(dev, dma_base, size, iommu))
 		dma_ops = arm_get_iommu_dma_map_ops(coherent);
-- 
1.7.9.5

  parent reply	other threads:[~2015-01-23 22:32 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 22:32 [PATCH v4 0/6] PCI: get DMA configuration from parent device Murali Karicheri
     [not found] ` <1422052359-12384-1-git-send-email-m-karicheri2-l0cyMroinI0@public.gmane.org>
2015-01-23 22:32   ` [PATCH v4 1/6] of: iommu: add ptr to OF node arg to of_iommu_configure() Murali Karicheri
     [not found]     ` <1422052359-12384-2-git-send-email-m-karicheri2-l0cyMroinI0@public.gmane.org>
2015-01-25 13:32       ` Laurent Pinchart
2015-01-26 18:49         ` Murali Karicheri
     [not found]           ` <54C68C1D.5030605-l0cyMroinI0@public.gmane.org>
2015-01-28 11:33             ` Will Deacon
     [not found]               ` <20150128113300.GF1569-5wv7dgnIgG8@public.gmane.org>
2015-01-28 12:23                 ` Laurent Pinchart
2015-01-28 12:29                   ` Will Deacon
     [not found]                     ` <20150128122941.GK1569-5wv7dgnIgG8@public.gmane.org>
2015-01-28 13:15                       ` Laurent Pinchart
2015-01-28 13:32                         ` Will Deacon
     [not found]                           ` <20150128133219.GM1569-5wv7dgnIgG8@public.gmane.org>
2015-01-28 15:21                             ` Murali Karicheri
2015-01-28 23:32                             ` Laurent Pinchart
2015-01-29 14:59                               ` Murali Karicheri
2015-01-29 16:49                               ` Rob Herring
     [not found]                                 ` <CAL_Jsq+rzwk0Rw5RRKf9oLqXNFFgnJb4UQ_AzpJLxN1Z0rJWMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-30  0:24                                   ` Laurent Pinchart
2015-01-30 15:23                                     ` Murali Karicheri
2015-01-23 22:32   ` [PATCH v4 2/6] of: move of_dma_configure() to device.c to help re-use Murali Karicheri
2015-01-23 22:32   ` [PATCH v4 4/6] of/pci: add of_pci_dma_configure() update dma configuration Murali Karicheri
     [not found]     ` <1422052359-12384-5-git-send-email-m-karicheri2-l0cyMroinI0@public.gmane.org>
2015-01-23 23:41       ` Bjorn Helgaas
     [not found]         ` <20150123234124.GW29776-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-01-26 23:25           ` Murali Karicheri
     [not found]             ` <54C6CCF3.7080308-l0cyMroinI0@public.gmane.org>
2015-01-26 23:59               ` Bjorn Helgaas
     [not found]                 ` <CAErSpo4w0zVCmXk2D2Qk5W3kceS9Wk+=jqHBDwk6HUXWwXdq_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-27 18:14                   ` Murali Karicheri
     [not found]                     ` <54C7D576.6030502-l0cyMroinI0@public.gmane.org>
2015-01-27 18:42                       ` Bjorn Helgaas
     [not found]                         ` <CAErSpo4Awgqu0ZtoMm0XSZzhnYtXh3xxH2OJMkyth5YDR9GUiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-27 18:45                           ` Murali Karicheri
2015-01-23 22:32   ` [PATCH v4 5/6] PCI: update dma configuration from DT Murali Karicheri
     [not found]     ` <1422052359-12384-6-git-send-email-m-karicheri2-l0cyMroinI0@public.gmane.org>
2015-01-23 23:27       ` Bjorn Helgaas
     [not found]         ` <20150123232725.GV29776-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-01-26 23:28           ` Murali Karicheri
2015-01-23 22:32 ` [PATCH v4 3/6] of: fix size when dma-range is not used Murali Karicheri
2015-01-27 11:27   ` Robin Murphy
2015-01-27 15:44     ` Murali Karicheri
     [not found]     ` <54C77616.80301-5wv7dgnIgG8@public.gmane.org>
2015-01-27 18:55       ` Murali Karicheri
     [not found]         ` <54C7DF13.20402-l0cyMroinI0@public.gmane.org>
2015-01-28 11:05           ` Catalin Marinas
     [not found]             ` <20150128110523.GC6646-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2015-01-28 15:45               ` Rob Herring
     [not found]                 ` <CAL_JsqJiCKW0ny=_ueq=A7RH3octpEhN+KZuLZhbNEHusyjcig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-28 17:23                   ` Catalin Marinas
2015-01-28 17:34                   ` Murali Karicheri
2015-01-28 15:55               ` Robin Murphy
     [not found]                 ` <54C9068D.8050701-5wv7dgnIgG8@public.gmane.org>
2015-01-28 17:30                   ` Catalin Marinas
2015-01-30 18:06                     ` Murali Karicheri
     [not found]                       ` <54CBC823.3020905-l0cyMroinI0@public.gmane.org>
2015-02-02 12:18                         ` Catalin Marinas
     [not found]                           ` <20150202121843.GD22661-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2015-02-02 16:10                             ` Murali Karicheri
2015-02-05 21:42                           ` Murali Karicheri
     [not found]                             ` <54D3E3C3.1040104-l0cyMroinI0@public.gmane.org>
2015-02-05 22:44                               ` Catalin Marinas
2015-01-23 22:32 ` Murali Karicheri [this message]
     [not found]   ` <1422052359-12384-7-git-send-email-m-karicheri2-l0cyMroinI0@public.gmane.org>
2015-01-27 11:12     ` [PATCH v4 6/6] arm: dma-mapping: updates to limit dma_mask and iommu mapping size Robin Murphy
     [not found]       ` <54C772A0.2000203-5wv7dgnIgG8@public.gmane.org>
2015-01-27 11:34         ` Catalin Marinas
     [not found]           ` <20150127113416.GB3226-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2015-01-27 15:19             ` Murali Karicheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422052359-12384-7-git-send-email-m-karicheri2@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).