Re: [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.

Suman Tripathi
2015-01-28T04:23:25Z

Hi Arnd,

I added the iommus in the IOMMU AHBC patch. Anything wrong in that ?
In the next version Also I will remove the IOMMU hacks from arasan
driver

On Wed, Jan 28, 2015 at 9:48 AM, Suman Tripathi <stripathi@apm.com> wrote:
> Hi Arnd,
>
> On Tuesday 27 January 2015 22:51:00 Suman Tripathi wrote:
>>
>> + sdhc0: sdhc@1c000000 {
>> + device_type = "sdhc";
>> + compatible = "arasan,sdhci-8.9a";
>> + reg = <0x0 0x1c000000 0x0 0x100>;
>> + interrupts = <0x0 0x49 0x4>;
>> + clock-names = "clk_xin", "clk_ahb";
>> + clocks = <&sdioclk 0>, <&ahbclk 0>;
>> + };
>> +
>
> Here you don't provide an 'iommus' property, which means that the
> device is unable to use the iommu.
> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ? In the
> next version Also I will remove the IOMMU hacks from arasan driver
>
>
> On Wed, Jan 28, 2015 at 1:43 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> On Tuesday 27 January 2015 22:51:00 Suman Tripathi wrote:
>> >
>> > + sdhc0: sdhc@1c000000 {
>> > + device_type = "sdhc";
>> > + compatible = "arasan,sdhci-8.9a";
>> > + reg = <0x0 0x1c000000 0x0 0x100>;
>> > + interrupts = <0x0 0x49 0x4>;
>> > + clock-names = "clk_xin", "clk_ahb";
>> > + clocks = <&sdioclk 0>, <&ahbclk 0>;
>> > + };
>> > +
>>
>> Here you don't provide an 'iommus' property, which means that the
>> device is unable to use the iommu.
>>
>> Arnd
>
>
>
>
> --
> Thanks,
> with regards,
> Suman Tripathi

--
Thanks,
with regards,
Suman Tripathi