[PATCH] ARM: dts: exynos4412-trats2: set display clock correctly

[PATCH] ARM: dts: exynos4412-trats2: set display clock correctly

[Inki Dae]

This patch sets display clock correctly.

If Display clock isn't set correctly then you would find below messages
and Display controller doesn't work correctly since a patch[1]

   exynos-drm: No connectors reported connected with modes
   [drm] Cannot find any crtc or sizes - going 1024x768

[1] commit abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 arch/arm/boot/dts/exynos4412-trats2.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 29231b4..1ec4d33 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -691,7 +691,7 @@
 
 			display-timings {
 				timing-0 {
-					clock-frequency = <0>;
+					clock-frequency = <57153600>;
 					hactive = <720>;
 					vactive = <1280>;
 					hfront-porch = <5>;
-- 
1.7.9.5

Re: [PATCH] ARM: dts: exynos4412-trats2: set display clock correctly

[Krzysztof Kozlowski]

2015-02-07 19:49 GMT+09:00 Inki Dae <inki.dae@samsung.com>:
> This patch sets display clock correctly.
>
> If Display clock isn't set correctly then you would find below messages
> and Display controller doesn't work correctly since a patch[1]
>
>    exynos-drm: No connectors reported connected with modes
>    [drm] Cannot find any crtc or sizes - going 1024x768
>
> [1] commit abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Tested on Trats2 board.

Dear Kukjin,

Could you pull it to current fixes branch (this RC cycle)? The patch
fixes display on Trats2 board. Without it (since abc0b1447d49) it
won't be properly set up and device boots with blank screen and
mentioned error message in logs.

I think this actually is a candidate for stable backporting (4.0+)
because it fixes important functionality of device:

Fixes: abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")
Cc: <stable@vger.kernel.org>

Best regards,
Krzysztof

Re: [PATCH] ARM: dts: exynos4412-trats2: set display clock correctly

[Kukjin Kim]

On 05/20/15 09:12, Krzysztof Kozlowski wrote:
> 2015-02-07 19:49 GMT+09:00 Inki Dae <inki.dae@samsung.com>:
>> This patch sets display clock correctly.
>>
>> If Display clock isn't set correctly then you would find below messages
>> and Display controller doesn't work correctly since a patch[1]
>>
>>    exynos-drm: No connectors reported connected with modes
>>    [drm] Cannot find any crtc or sizes - going 1024x768
>>
>> [1] commit abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Tested on Trats2 board.
> 
> Dear Kukjin,
> 
> Could you pull it to current fixes branch (this RC cycle)? The patch
> fixes display on Trats2 board. Without it (since abc0b1447d49) it
> won't be properly set up and device boots with blank screen and
> mentioned error message in logs.
> 
> I think this actually is a candidate for stable backporting (4.0+)
> because it fixes important functionality of device:
> 
> Fixes: abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")
> Cc: <stable@vger.kernel.org>
> 
Thanks, applied, and will be sent out in a day for v4.1-rc.

- Kukjin