From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver Date: Mon, 09 Feb 2015 16:27:13 -0800 Message-ID: <1423528033.2933.29.camel@perches.com> References: <1423526830-29516-1-git-send-email-sbranden@broadcom.com> <1423526830-29516-2-git-send-email-sbranden@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423526830-29516-2-git-send-email-sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Scott Branden Cc: bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Matt Mackall , Herbert Xu , Grant Likely , Ray Jui , Jonathan Richardson , Dmitry Torokhov , Anatol Pomazao , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote: > This adds a driver for random number generator present on Broadcom > IPROC devices. trivia: > diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c [] > +static int iproc_rng200_probe(struct platform_device *pdev) > +{ [] > + if (!res) { > + dev_err(dev, "failed to get rng resources"); Missing terminating newline: dev_err(dev, "failed to get rng resources\n"); > + rng_base = devm_ioremap_resource(dev, res); > + if (!rng_base) { > + dev_err(dev, "failed to remap rng regs"); here too. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html