From: Paul Bolle <pebolle@tiscali.nl>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm: jz4780: Add DRM driver for Ingenic JZ4780
Date: Wed, 04 Mar 2015 22:38:48 +0100 [thread overview]
Message-ID: <1425505128.2090.41.camel@tiscali.nl> (raw)
In-Reply-To: <1425483471-59808-4-git-send-email-Zubair.Kakakhel@imgtec.com>
Zubair Lutfullah Kakakhel schreef op wo 04-03-2015 om 15:37 [+0000]:
> --- /dev/null
> +++ b/drivers/gpu/drm/jz4780/Makefile
> @@ -0,0 +1,10 @@
> +ccflags-y := -Iinclude/drm
> +ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
> +
> +endif
What does that do?
> +jz4780-y := \
> + jz4780_crtc.o \
> + jz4780_drv.o
Please make this one line.
> +obj-$(CONFIG_DRM_JZ4780) += jz4780.o
> --- /dev/null
> +++ b/drivers/gpu/drm/jz4780/jz4780_drv.c
> @@ -0,0 +1,388 @@
> +/*
> + * Copyright (C) 2015 Imagination Technologies
> + * Author: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> + *
> + * DRM driver for Ingenic JZ4780
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published by
> + * the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + */
This states the license is GPL v2. (I think the other files of this
driver carry similar comments.)
> +MODULE_LICENSE("GPL");
So you probably want
MODULE_LICENSE("GPL v2");
here.
Paul Bolle
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-04 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 15:37 [PATCH 0/5] drm: dt: jz4780: Add Ingenic JZ4780 driver Zubair Lutfullah Kakakhel
2015-03-04 15:37 ` [PATCH 1/5] dt-bindings: video: Add Ingenic jz4780-drm binding Zubair Lutfullah Kakakhel
2015-03-04 15:37 ` [PATCH 2/5] dt-bindings: video: Add jz4780-lcd binding Zubair Lutfullah Kakakhel
2015-03-04 15:37 ` [PATCH 3/5] drm: jz4780: Add DRM driver for Ingenic JZ4780 Zubair Lutfullah Kakakhel
2015-03-04 21:38 ` Paul Bolle [this message]
2015-03-04 15:37 ` [PATCH 4/5] dt-bindings: video: Add jz4780-hdmi binding Zubair Lutfullah Kakakhel
[not found] ` <1425483471-59808-1-git-send-email-Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-03-04 15:37 ` [PATCH 5/5] drm: bridge/dw_hdmi: add jz4780 support Zubair Lutfullah Kakakhel
2015-03-04 21:30 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425505128.2090.41.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).