From: Axel Lin <axel.lin@ingics.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
Lee Jones <lee.jones@linaro.org>,
Alexandre Torgue <alexandre.torgue@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: [PATCH 1/2] phy: miphy365x: Convert to devm_kcalloc and fix wrong sizof
Date: Thu, 05 Mar 2015 09:52:59 +0800 [thread overview]
Message-ID: <1425520379.1637.7.camel@phoenix> (raw)
Prefer devm_kcalloc over devm_kzalloc with multiply.
In additional, use sizeof(phy) is incorrect, fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/phy/phy-miphy365x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/phy-miphy365x.c b/drivers/phy/phy-miphy365x.c
index 61177a6..51b459d 100644
--- a/drivers/phy/phy-miphy365x.c
+++ b/drivers/phy/phy-miphy365x.c
@@ -549,9 +549,8 @@ static int miphy365x_probe(struct platform_device *pdev)
return -ENOMEM;
miphy_dev->nphys = of_get_child_count(np);
- miphy_dev->phys = devm_kzalloc(&pdev->dev,
- sizeof(phy) * miphy_dev->nphys,
- GFP_KERNEL);
+ miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
+ sizeof(*miphy_dev->phys), GFP_KERNEL);
if (!miphy_dev->phys)
return -ENOMEM;
--
1.9.1
next reply other threads:[~2015-03-05 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 1:52 Axel Lin [this message]
2015-03-05 1:57 ` [RFC][PATCH 2/2] phy: miphy365x: Convert to use phy.h instead of phy-miphy365x.h Axel Lin
2015-03-05 7:54 ` Lee Jones
2015-03-09 11:44 ` Kishon Vijay Abraham I
[not found] ` <54FD8795.6020409-l0cyMroinI0@public.gmane.org>
2015-03-09 13:25 ` Axel Lin
[not found] ` <CAFRkauBNEgMiQtHxVuz_rif7+AWBjXoLVydidzjxK-oMWYxCrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-25 23:11 ` Kishon Vijay Abraham I
[not found] ` <551340B4.2010001-l0cyMroinI0@public.gmane.org>
2015-03-26 8:48 ` Patrice Chotard
2015-03-05 7:53 ` [PATCH 1/2] phy: miphy365x: Convert to devm_kcalloc and fix wrong sizof Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425520379.1637.7.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gabriel.fernandez@st.com \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).