devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs
Date: Thu, 05 Mar 2015 20:13:43 +0100	[thread overview]
Message-ID: <1425582823.24292.225.camel@x220> (raw)
In-Reply-To: <1425576461-52412-3-git-send-email-Zubair.Kakakhel@imgtec.com>

On Thu, 2015-03-05 at 17:27 +0000, Zubair Lutfullah Kakakhel wrote:
> --- /dev/null
> +++ b/drivers/mtd/nand/jz4780_bch.c
> @@ -0,0 +1,359 @@
> +/*
> + * JZ4780 BCH controller
> + *
> + * Copyright (c) 2015 Imagination Technologies
> + * Author: Alex Smith <alex@alex-smith.me.uk>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL v2");

So you probably want
    MODULE_LICENSE("GPL");

here.

> --- /dev/null
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -0,0 +1,373 @@
> +/*
> + * JZ4780 NAND driver
> + *
> + * Copyright (c) 2015 Imagination Technologies
> + * Author: Alex Smith <alex@alex-smith.me.uk>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL V2");

So, again, you probably want
    MODULE_LICENSE("GPL");

here.

Actually "GPL V2" would taint the kernel on module load.

(This all assumes we're talking about two separate modules here. I don't
speak "Makefile" enough to be sure.)


Paul Bolle

      reply	other threads:[~2015-03-05 19:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 17:27 [PATCH 0/2] mtd: nand: jz4780: Add nand and bch driver Zubair Lutfullah Kakakhel
2015-03-05 17:27 ` [PATCH 1/2] dt-bindings: binding for jz4780-{nand,bch} Zubair Lutfullah Kakakhel
2015-03-05 17:27 ` [PATCH 2/2] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs Zubair Lutfullah Kakakhel
2015-03-05 19:13   ` Paul Bolle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425582823.24292.225.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).