From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wu Subject: Re: [PATCH 5/5] dts: mt8173: Add iommu/smi nodes for mt8173 Date: Mon, 9 Mar 2015 20:18:34 +0800 Message-ID: <1425903514.13300.35.camel@mhfsdcap03> References: <1425638900-24989-1-git-send-email-yong.wu@mediatek.com> <1425638900-24989-6-git-send-email-yong.wu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Kurtz Cc: Rob Herring , Joerg Roedel , Matthias Brugger , Robin Murphy , Will Deacon , Tomasz Figa , Lucas Stach , Mark Rutland , Catalin Marinas , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sasha Hauer , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, "open list:OPEN FIRMWARE AND..." , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "open list:IOMMU DRIVERS" List-Id: devicetree@vger.kernel.org Dear Daniel, Thanks very much. I will fix this in next version. On Sat, 2015-03-07 at 23:20 +0800, Daniel Kurtz wrote: > Hi Yong, > > On Fri, Mar 6, 2015 at 6:48 PM, wrote: > > From: Yong Wu > > > > This patch add the iommu/larbs nodes for mt8173 > > > > Signed-off-by: Yong Wu > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 60 ++++++++++++ > > include/dt-bindings/iommu/mt8173-iommu-port.h | 127 ++++++++++++++++++++++++++ > > 2 files changed, 187 insertions(+) > > create mode 100644 include/dt-bindings/iommu/mt8173-iommu-port.h > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index c2a057f..805a7cd 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -16,6 +16,7 @@ > > #include > > #include "mt8173-pinfunc.h" > > #include > > +#include > > > > / { > > compatible = "mediatek,mt8173"; > > @@ -249,6 +250,65 @@ > > interrupts = <0 86 8>; > > clocks = <&uart_clk>; > > }; > > + > > + iommu: mmsys_iommu@10205000 { > > + compatible = "mediatek,mt8173-iommu"; > > + reg = <0 0x10205000 0 0x1000>; > > + interrupts = ; > > + clocks = <&infrasys INFRA_M4U>; > > + clock-names = "infra_m4u"; > > + larb = <&larb0 &larb1 &larb2 &larb3 &larb4 &larb5>; > > + #iommu-cells = <1>; > > + }; > > + > > + larb0:larb@14021000 { > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x14021000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, <&mmsys MM_SMI_LARB0>; > > + clock-names = "larb_sub0", "larb_sub1"; > > + }; > > + > > + larb1:larb@16010000 { > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x16010000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, > > + <&vdecsys VDEC_CKEN>, > > + <&vdecsys VDEC_LARB_CKEN>; > > + clock-names = "larb_sub0", "larb_sub1", "larb_sub2"; > > + }; > > + > > + larb2:larb@16010000 { > > I think this one should be: > larb2: larb@15001000 { > > Also, I am not a devicetree expert, but I believe nodes are usually > arranged in register order. > If that is the case, the order, as unfortunate as this looks, should be: > > larb0: larb@14021000 > larb4: larb@14027000 > larb2: larb@15001000 > larb1: larb@16010000 > larb3: larb@18001000 > larb5: larb@19001000 > > -Dan > > > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x15001000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, > > + <&imgsys IMG_LARB2_SMI>; > > + clock-names = "larb_sub0", "larb_sub1"; > > + }; > > + > > + larb3:larb@18001000 { > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x18001000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, > > + <&vencsys VENC_CKE0>, > > + <&vencsys VENC_CKE1>; > > + clock-names = "larb_sub0", "larb_sub1", "larb_sub2"; > > + }; > > + > > + larb4:larb@14027000 { > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x14027000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, <&mmsys MM_SMI_LARB4>; > > + clock-names = "larb_sub0", "larb_sub1"; > > + }; > > + > > + larb5:larb@19001000 { > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x19001000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, > > + <&vencltsys VENCLT_CKE0>, > > + <&vencltsys VENCLT_CKE1>; > > + clock-names = "larb_sub0", "larb_sub1", "larb_sub2"; > > + }; > > }; > > > > }; > > -- > > 1.8.1.1.dirty -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html