From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wu Subject: Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding Date: Mon, 9 Mar 2015 20:55:03 +0800 Message-ID: <1425905703.13300.48.camel@mhfsdcap03> References: <1425638900-24989-1-git-send-email-yong.wu@mediatek.com> <1425638900-24989-4-git-send-email-yong.wu@mediatek.com> <20150306111338.GD8700@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150306111338.GD8700@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Mark Rutland Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org" , Catalin Marinas , Will Deacon , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Tomasz Figa , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Rob Herring , Daniel Kurtz , yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sasha Hauer , Matthias Brugger , "linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Lucas Stach List-Id: devicetree@vger.kernel.org Dear Mark, Thanks very much for you suggestion. On Fri, 2015-03-06 at 11:13 +0000, Mark Rutland wrote: > On Fri, Mar 06, 2015 at 10:48:18AM +0000, yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > > From: Yong Wu > > > > This patch add smi binding document. > > Please move binding documents to the start of the series. It makes > things far easier to review. > > > > > Signed-off-by: Yong Wu > > --- > > .../devicetree/bindings/soc/mediatek/mediatek,smi.txt | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > > new file mode 100644 > > index 0000000..0fc9d1a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > > @@ -0,0 +1,17 @@ > > +SMI hardware block diagram please help check > > + > > +Required properties: > > +- compatible : must be "mediatek,mediatek,mt8173-smi-larb" > > Double vendor prefix? Yes. I will change this. > > What does "larb" mean? It would be nice for the intorductory paragraph > in this file to explain. That is local arbiter. I will add a link like this, is it ok? compatible : must be "mediatek,mt8173-smi-larb", about the "larb", please check the . > > > +- reg : the register of each local arbiter > > +- clocks : the clocks of each local arbiter > > +- clock-name: larb_sub*(3 clockes at most) > > The names required _must_ be specified here, or clock-names is > pointless. > > The clock names should be from the PoV of _this_ device (i.e. they > should be the names of the inputs) not from the PoV of the provider > (i.e. they should not be the names of the outputs from the provider). I use larb_sub0, larb_sub1,larb_sub2 for more easily to control the clocks. if we use the PoV, We should list all the clocks name, it will has a little code. Anyway I will change this in the next version. > > Mark. > > > + > > +Example: > > + larb1:larb@16010000 { > > + compatible = "mediatek,mt8173-smi-larb"; > > + reg = <0 0x16010000 0 0x1000>; > > + clocks = <&mmsys MM_SMI_COMMON>, > > + <&vdecsys VDEC_CKEN>, > > + <&vdecsys VDEC_LARB_CKEN>; > > + clock-names = "larb_sub0", "larb_sub1", "larb_sub2"; > > + }; > > -- > > 1.8.1.1.dirty > > > >