From: Wang Long <long.wanglong@huawei.com>
To: gaurav.minocha.os@gmail.com, robherring2@gmail.com,
robh+dt@kernel.org, pantelis.antoniou@konsulko.com,
grant.likely@linaro.org
Cc: pawel.moll@arm.com, mark.rutland@arm.com, galak@codeaurora.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
peifeiyue@huawei.com, long.wanglong@huawei.com,
ijc+devicetree@hellion.org.uk
Subject: [PATCH v2 1/5] of/unittest: remove the duplicate of_changeset_init
Date: Wed, 11 Mar 2015 08:36:50 +0000 [thread overview]
Message-ID: <1426063014-211712-2-git-send-email-long.wanglong@huawei.com> (raw)
In-Reply-To: <1426063014-211712-1-git-send-email-long.wanglong@huawei.com>
Remove the duplicate of_changeset_init. In of_selftest_changeset
testcase, the "struct of_changeset chgset" is initialized twice,
but only once is enough. so, drop the first initializtion code.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
drivers/of/unittest.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 0cf9a23..199fb23 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -478,7 +478,6 @@ static void __init of_selftest_changeset(void)
struct device_node *n1, *n2, *n21, *nremove, *parent, *np;
struct of_changeset chgset;
- of_changeset_init(&chgset);
n1 = __of_node_dup(NULL, "/testcase-data/changeset/n1");
selftest(n1, "testcase setup failure\n");
n2 = __of_node_dup(NULL, "/testcase-data/changeset/n2");
--
1.8.3.4
next prev parent reply other threads:[~2015-03-11 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 8:36 [PATCH v2 0/5] Update the OF unittest and some small fix Wang Long
2015-03-11 8:36 ` Wang Long [this message]
2015-03-11 8:36 ` [PATCH v2 2/5] of/unittest: Fix the wrong expected value in of_selftest_property_string Wang Long
2015-03-11 8:36 ` [PATCH v2 3/5] Documentation: update the of_selftest.txt Wang Long
[not found] ` <1426063014-211712-1-git-send-email-long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-03-11 8:36 ` [PATCH v2 4/5] Documentation: rename of_selftest.txt to of_unittest.txt Wang Long
2015-03-11 8:36 ` [PATCH v2 5/5] of/unittest: replace 'selftest' with 'unittest' Wang Long
2015-03-25 4:43 ` [PATCH v2 0/5] Update the OF unittest and some small fix Rob Herring
2015-03-28 13:23 ` Grant Likely
[not found] ` <20150328132347.84128C4093E-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2015-03-29 17:24 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426063014-211712-2-git-send-email-long.wanglong@huawei.com \
--to=long.wanglong@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gaurav.minocha.os@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=pawel.moll@arm.com \
--cc=peifeiyue@huawei.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).