From: Philipp Zabel <p.zabel@pengutronix.de>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
dianders@chromium.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, Yakir Yang <ykk@rock-chips.com>,
Andy Yan <andy.yan@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] drm/bridge: dw-hdmi: support optional supply regulators
Date: Wed, 11 Mar 2015 10:28:29 +0100 [thread overview]
Message-ID: <1426066109.3101.46.camel@pengutronix.de> (raw)
In-Reply-To: <2265807.RXHBN9kUi4@phil>
Hi Heiko,
Am Dienstag, den 10.03.2015, 22:45 +0100 schrieb Heiko Stuebner:
> At least the Rockchip variant of the dw_hdmi can have controllable power supplies
> providing 1.0 and 1.8V. Therefore add the possibility for the generic bridge
> driver to enable supplies provided by the hw-specific drivers.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> changes since v1:
> - follow suggestion from Russell King to keep regulator handling local
> to the rockchip implementation for the time being and only generalize
> when a real second implementation needs regulator handling
>
> .../devicetree/bindings/drm/bridge/dw_hdmi.txt | 5 ++++
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 32 +++++++++++++++++++++-
> 2 files changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
> index a905c14..bb74640 100644
> --- a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
> +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
> @@ -22,6 +22,11 @@ Optional properties
> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> - clocks, clock-names: phandle to the HDMI CEC clock, name should be "cec"
>
> +Optional supplies:
> +rockchip,rk3288-dw-hdmi handles two optional power supplies:
> +- avdd1v0-supply: 1.0V power supply
> +- avdd1v8-supply: 1.8V power supply
Are these the names used in the Rockchip documentation?
Since the older implementation on i.MX6 uses 1.1V (HDMI_VP) and 2.5V
(HDMI_VPH), I wonder whether each SoC should use their own name or
whether there should be common names that don't include the voltage.
I don't have the Synopsys HDMI TX docs, but I've seen avddhv and avddlv
used of other cores' analog supplies.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-11 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 21:45 [PATCH v2 1/2] drm/bridge: dw-hdmi: support optional supply regulators Heiko Stuebner
2015-03-10 21:46 ` [PATCH v2 2/2] ARM: dts: rockchip: add hdmi analog power supplies to rk3288 boards Heiko Stuebner
2015-03-11 9:28 ` Philipp Zabel [this message]
2015-03-11 9:50 ` [PATCH v2 1/2] drm/bridge: dw-hdmi: support optional supply regulators Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426066109.3101.46.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).