From: Jacek Anaszewski <j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org,
cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org,
sakari.ailus-X3B1VOXEql0@public.gmane.org,
s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
Jacek Anaszewski
<j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH/RFC v13 01/13] leds: flash: Fix the size of sysfs_groups array
Date: Thu, 12 Mar 2015 16:45:02 +0100 [thread overview]
Message-ID: <1426175114-14876-2-git-send-email-j.anaszewski@samsung.com> (raw)
In-Reply-To: <1426175114-14876-1-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
LED_FLASH_MAX_SYSFS_GROUPS macro had value that was relevant for
previous version of the patches introducing LED Flash class. Currently
it is required to reserve the room for maximum 4 sysfs groups.
Since the last element of the struct attribute_group array passed to
the function device_create_with_groups has to be NULL, the size of the
array has to be greater by one than maximum allowed number of groups.
Therefore, the name of the macro is being changed to
LED_FLASH_SYSFS_GROUPS_SIZE, to make it more accurrate.
Signed-off-by: Jacek Anaszewski <j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Acked-by: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>
---
include/linux/led-class-flash.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/led-class-flash.h b/include/linux/led-class-flash.h
index 21ec91e..e97966d 100644
--- a/include/linux/led-class-flash.h
+++ b/include/linux/led-class-flash.h
@@ -32,7 +32,7 @@ struct led_classdev_flash;
#define LED_FAULT_LED_OVER_TEMPERATURE (1 << 8)
#define LED_NUM_FLASH_FAULTS 9
-#define LED_FLASH_MAX_SYSFS_GROUPS 7
+#define LED_FLASH_SYSFS_GROUPS_SIZE 5
struct led_flash_ops {
/* set flash brightness */
@@ -80,7 +80,7 @@ struct led_classdev_flash {
struct led_flash_setting timeout;
/* LED Flash class sysfs groups */
- const struct attribute_group *sysfs_groups[LED_FLASH_MAX_SYSFS_GROUPS];
+ const struct attribute_group *sysfs_groups[LED_FLASH_SYSFS_GROUPS_SIZE];
};
static inline struct led_classdev_flash *lcdev_to_flcdev(
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-12 15:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 15:45 [PATCH/RFC v13 00/13] LED / flash API integration Jacek Anaszewski
[not found] ` <1426175114-14876-1-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-03-12 15:45 ` Jacek Anaszewski [this message]
2015-03-12 15:45 ` [PATCH/RFC v13 02/13] dt-binding: leds: Add common LED DT bindings macros Jacek Anaszewski
2015-03-18 1:33 ` Bryan Wu
2015-03-12 15:45 ` [PATCH/RFC v13 03/13] leds: Add support for max77693 mfd flash cell Jacek Anaszewski
2015-03-23 11:56 ` Lee Jones
2015-03-23 12:07 ` Lee Jones
2015-03-12 15:45 ` [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693 Jacek Anaszewski
2015-03-23 12:07 ` Lee Jones
2015-03-23 14:22 ` Pavel Machek
2015-03-23 15:02 ` Lee Jones
2015-03-23 15:48 ` Pavel Machek
2015-03-23 15:59 ` Lee Jones
2015-03-23 18:28 ` Sylwester Nawrocki
2015-04-02 14:50 ` Pavel Machek
2015-04-02 19:33 ` Lee Jones
2015-03-12 15:45 ` [PATCH/RFC v13 05/13] leds: Add driver for AAT1290 current regulator Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 06/13] of: Add Skyworks Solutions, Inc. vendor prefix Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 07/13] DT: Add documentation for the Skyworks AAT1290 Jacek Anaszewski
2015-03-18 10:28 ` Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 08/13] exynos4-is: Add support for v4l2-flash subdevs Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 09/13] media: Add registration helpers for V4L2 flash sub-devices Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 10/13] Documentation: leds: Add description of v4l2-flash sub-device Jacek Anaszewski
2015-03-18 12:39 ` Sakari Ailus
2015-03-18 14:36 ` Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 11/13] DT: Add documentation for exynos4-is 'flashes' property Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 12/13] leds: max77693: add support for V4L2 Flash sub-device Jacek Anaszewski
2015-03-12 15:45 ` [PATCH/RFC v13 13/13] leds: aat1290: " Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426175114-14876-2-git-send-email-j.anaszewski@samsung.com \
--to=j.anaszewski-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
--cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).