From: Kenneth Westfield <kwestfie@codeaurora.org>
To: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Kumar Gala <galak@codeaurora.org>
Cc: Banajit Goswami <bgoswami@codeaurora.org>,
Patrick Lai <plai@codeaurora.org>, Takashi Iwai <tiwai@suse.de>,
Jaroslav Kysela <perex@perex.cz>,
David Brown <davidb@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
ALSA Mailing List <alsa-devel@alsa-project.org>,
MSM Mailing List <linux-arm-msm@vger.kernel.org>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kenneth Westfield <kwestfie@codeaurora.org>
Subject: [PATCH 2/2] ASoC: qcom: Modify test for DSP in LPASS driver
Date: Fri, 13 Mar 2015 00:54:17 -0700 [thread overview]
Message-ID: <1426233257-27532-2-git-send-email-kwestfie@codeaurora.org> (raw)
In-Reply-To: <1426233257-27532-1-git-send-email-kwestfie@codeaurora.org>
From: Kenneth Westfield <kwestfie@codeaurora.org>
As the representation of the DSP in the device
tree has changed from a required subnode to an
optional phandle, modify the test for DSP
existence in the LPASS CPU DAI driver,
accordingly.
Signed-off-by: Kenneth Westfield <kwestfie@codeaurora.org>
---
sound/soc/qcom/lpass-cpu.c | 33 +++++++--------------------------
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index d5167131787f3a7663665c94dffe6899bd050179..6698d058de29600a464be79490bec641736819c3 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b/sound/soc/qcom/lpass-cpu.c
@@ -359,45 +359,26 @@ static const struct regmap_config lpass_cpu_regmap_config = {
.cache_type = REGCACHE_FLAT,
};
-static int lpass_cpu_parse_of(struct device *dev)
+static int lpass_cpu_platform_probe(struct platform_device *pdev)
{
+ struct lpass_data *drvdata;
struct device_node *dsp_of_node;
+ struct resource *res;
+ int ret;
- dsp_of_node = of_get_child_by_name(dev->of_node, "qcom,adsp");
- if (!dsp_of_node) {
- dev_err(dev, "%s() error getting qcom,adsp sub-node\n",
- __func__);
- return -EINVAL;
- }
-
- if (of_device_is_available(dsp_of_node)) {
- dev_err(dev, "%s() DSP exists and holds audio resources\n",
+ dsp_of_node = of_parse_phandle(pdev->dev.of_node, "qcom,adsp", 0);
+ if (dsp_of_node) {
+ dev_err(&pdev->dev, "%s() DSP exists and holds audio resources\n",
__func__);
return -EBUSY;
}
- return 0;
-}
-
-static int lpass_cpu_platform_probe(struct platform_device *pdev)
-{
- struct lpass_data *drvdata;
- struct resource *res;
- int ret;
-
drvdata = devm_kzalloc(&pdev->dev, sizeof(struct lpass_data),
GFP_KERNEL);
if (!drvdata)
return -ENOMEM;
platform_set_drvdata(pdev, drvdata);
- ret = lpass_cpu_parse_of(&pdev->dev);
- if (ret) {
- dev_err(&pdev->dev, "%s() error getting DT node info: %d\n",
- __func__, ret);
- return ret;
- }
-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");
if (!res) {
dev_err(&pdev->dev, "%s() error getting resource\n", __func__);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-03-13 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 7:54 [PATCH 1/2] ASoC: qcom: Change qcom,adsp in LPASS CPU bindings Kenneth Westfield
2015-03-13 7:54 ` Kenneth Westfield [this message]
2015-03-16 11:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426233257-27532-2-git-send-email-kwestfie@codeaurora.org \
--to=kwestfie@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).