From: Anand Moon <linux.amoon@gmail.com>
To: Lukasz Majewski <l.majewski@samsung.com>,
Eduardo Valentin <edubezval@gmail.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, Anand Moon <linux.amoon@gmail.com>
Subject: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
Date: Fri, 27 Mar 2015 03:09:15 +1030 [thread overview]
Message-ID: <1427387955-5129-7-git-send-email-linux.amoon@gmail.com> (raw)
In-Reply-To: <1427387955-5129-1-git-send-email-linux.amoon@gmail.com>
Below changes depend on following patch.
https://patchwork.kernel.org/patch/5944061/
Update the pwm_config with duty then update the pwm_disable
to poweroff the cpu fan.
Tested on OdroidXU3 board.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/hwmon/pwm-fan.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 7c83dc4..f25c841 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -44,26 +44,24 @@ static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
int ret = 0;
mutex_lock(&ctx->lock);
+
if (ctx->pwm_value == pwm)
goto exit_set_pwm_err;
- if (pwm == 0) {
- pwm_disable(ctx->pwm);
- goto exit_set_pwm;
- }
-
duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM);
ret = pwm_config(ctx->pwm, duty, ctx->pwm->period);
if (ret)
goto exit_set_pwm_err;
+ if (pwm == 0)
+ pwm_disable(ctx->pwm);
+
if (ctx->pwm_value == 0) {
ret = pwm_enable(ctx->pwm);
if (ret)
goto exit_set_pwm_err;
}
-exit_set_pwm:
ctx->pwm_value = pwm;
exit_set_pwm_err:
mutex_unlock(&ctx->lock);
--
1.9.1
next prev parent reply other threads:[~2015-03-26 16:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 16:39 Exynos5422 odroidxu3 pwm-fan control using thermal sensors Anand Moon
2015-03-26 16:39 ` [PATCH 1/6] ARM: dts :exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board Anand Moon
2015-04-08 7:46 ` Lukasz Majewski
2015-03-26 16:39 ` [PATCH 2/6] ARM: dts exynos5420 update the cooling cells for core cpu0 Anand Moon
2015-04-08 7:47 ` Lukasz Majewski
2015-03-26 16:39 ` [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0 Anand Moon
2015-04-08 8:02 ` Lukasz Majewski
2015-04-08 9:12 ` Anand Moon
2015-04-08 9:30 ` Lukasz Majewski
2015-04-08 9:44 ` Anand Moon
2015-03-26 16:39 ` [PATCH 4/6] ARM: dts: OdroidXU3: Enable TMU at Exynos5422 base Anand Moon
2015-04-08 8:03 ` Lukasz Majewski
2015-03-26 16:39 ` [PATCH 5/6] pwm: samsung: Fix output race on disabling Anand Moon
2015-04-08 8:28 ` Lukasz Majewski
2015-04-08 8:42 ` Sjoerd Simons
2015-04-08 8:53 ` Anand Moon
2015-03-26 16:39 ` Anand Moon [this message]
2015-04-08 8:44 ` [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan Lukasz Majewski
2015-04-08 13:11 ` Guenter Roeck
2015-04-08 15:32 ` Guenter Roeck
2015-04-08 16:02 ` Anand Moon
2015-04-08 16:53 ` Guenter Roeck
2015-04-08 17:49 ` Anand Moon
2015-04-10 11:28 ` Anand Moon
2015-04-10 12:00 ` Sjoerd Simons
[not found] ` <1428667201.22057.20.camel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-04-10 12:59 ` Anand Moon
2015-04-10 13:09 ` Guenter Roeck
2015-04-10 13:17 ` Anand Moon
2015-04-10 13:30 ` Sjoerd Simons
2015-04-10 13:58 ` Thierry Reding
2015-04-10 17:25 ` Ben Gamari
2015-04-10 17:58 ` Guenter Roeck
2015-04-02 10:02 ` Exynos5422 odroidxu3 pwm-fan control using thermal sensors Markus Reichl
2015-04-02 10:06 ` Markus Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427387955-5129-7-git-send-email-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).