* [PATCH] of: Explicitly include linux/types.h in of_graph.h
@ 2015-03-26 16:47 Mark Brown
[not found] ` <1427388475-29096-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2015-03-26 16:47 UTC (permalink / raw)
To: Grant Likely, Rob Herring, Philipp Zabel, Laurent Pinchart
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
kernel-build-reports-cunTk1MwBs8s++Sfvej+rw, Mark Brown
In current -next of_graph.h fails to build due to it relying on
linux/types.h without explicitly including it:
../include/linux/of_graph.h:43:71: error: unknown type name 'u32'
caused by bfe446e37c4e (of: Add of_graph_get_port_by_id function). Add
an explicit inclusion to fix this.
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
include/linux/of_graph.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h
index 3c1c95a39e0c..7bc92e050608 100644
--- a/include/linux/of_graph.h
+++ b/include/linux/of_graph.h
@@ -14,6 +14,8 @@
#ifndef __LINUX_OF_GRAPH_H
#define __LINUX_OF_GRAPH_H
+#include <linux/types.h>
+
/**
* struct of_endpoint - the OF graph endpoint data structure
* @port: identifier (value of reg property) of a port this endpoint belongs to
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] of: Explicitly include linux/types.h in of_graph.h
[not found] ` <1427388475-29096-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2015-03-26 16:55 ` Laurent Pinchart
2015-03-26 17:08 ` Philipp Zabel
2015-03-26 18:46 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2015-03-26 16:55 UTC (permalink / raw)
To: Mark Brown
Cc: Grant Likely, Rob Herring, Philipp Zabel,
devicetree-u79uwXL29TY76Z2rM5mHXA,
kernel-build-reports-cunTk1MwBs8s++Sfvej+rw
Hi Mark,
Thank you for the patch.
On Thursday 26 March 2015 09:47:55 Mark Brown wrote:
> In current -next of_graph.h fails to build due to it relying on
> linux/types.h without explicitly including it:
>
> ../include/linux/of_graph.h:43:71: error: unknown type name 'u32'
>
> caused by bfe446e37c4e (of: Add of_graph_get_port_by_id function). Add
> an explicit inclusion to fix this.
>
> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> ---
> include/linux/of_graph.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h
> index 3c1c95a39e0c..7bc92e050608 100644
> --- a/include/linux/of_graph.h
> +++ b/include/linux/of_graph.h
> @@ -14,6 +14,8 @@
> #ifndef __LINUX_OF_GRAPH_H
> #define __LINUX_OF_GRAPH_H
>
> +#include <linux/types.h>
> +
> /**
> * struct of_endpoint - the OF graph endpoint data structure
> * @port: identifier (value of reg property) of a port this endpoint
> belongs to
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of: Explicitly include linux/types.h in of_graph.h
[not found] ` <1427388475-29096-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-03-26 16:55 ` Laurent Pinchart
@ 2015-03-26 17:08 ` Philipp Zabel
2015-03-26 18:46 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2015-03-26 17:08 UTC (permalink / raw)
To: Mark Brown
Cc: Grant Likely, Rob Herring, Laurent Pinchart,
devicetree-u79uwXL29TY76Z2rM5mHXA,
kernel-build-reports-cunTk1MwBs8s++Sfvej+rw
Am Donnerstag, den 26.03.2015, 09:47 -0700 schrieb Mark Brown:
> In current -next of_graph.h fails to build due to it relying on
> linux/types.h without explicitly including it:
>
> ../include/linux/of_graph.h:43:71: error: unknown type name 'u32'
>
> caused by bfe446e37c4e (of: Add of_graph_get_port_by_id function). Add
> an explicit inclusion to fix this.
>
> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> include/linux/of_graph.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h
> index 3c1c95a39e0c..7bc92e050608 100644
> --- a/include/linux/of_graph.h
> +++ b/include/linux/of_graph.h
> @@ -14,6 +14,8 @@
> #ifndef __LINUX_OF_GRAPH_H
> #define __LINUX_OF_GRAPH_H
>
> +#include <linux/types.h>
> +
> /**
> * struct of_endpoint - the OF graph endpoint data structure
> * @port: identifier (value of reg property) of a port this endpoint belongs to
Acked-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Thanks!
Philipp
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] of: Explicitly include linux/types.h in of_graph.h
[not found] ` <1427388475-29096-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-03-26 16:55 ` Laurent Pinchart
2015-03-26 17:08 ` Philipp Zabel
@ 2015-03-26 18:46 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2015-03-26 18:46 UTC (permalink / raw)
To: Mark Brown
Cc: Grant Likely, Rob Herring, Philipp Zabel, Laurent Pinchart,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-build-reports-cunTk1MwBs8s++Sfvej+rw
On Thu, Mar 26, 2015 at 11:47 AM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> In current -next of_graph.h fails to build due to it relying on
> linux/types.h without explicitly including it:
>
> ../include/linux/of_graph.h:43:71: error: unknown type name 'u32'
>
> caused by bfe446e37c4e (of: Add of_graph_get_port_by_id function). Add
> an explicit inclusion to fix this.
>
> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Applied. Thanks.
Rob
> ---
> include/linux/of_graph.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h
> index 3c1c95a39e0c..7bc92e050608 100644
> --- a/include/linux/of_graph.h
> +++ b/include/linux/of_graph.h
> @@ -14,6 +14,8 @@
> #ifndef __LINUX_OF_GRAPH_H
> #define __LINUX_OF_GRAPH_H
>
> +#include <linux/types.h>
> +
> /**
> * struct of_endpoint - the OF graph endpoint data structure
> * @port: identifier (value of reg property) of a port this endpoint belongs to
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-26 18:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-26 16:47 [PATCH] of: Explicitly include linux/types.h in of_graph.h Mark Brown
[not found] ` <1427388475-29096-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-03-26 16:55 ` Laurent Pinchart
2015-03-26 17:08 ` Philipp Zabel
2015-03-26 18:46 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).