* SAM5D3 Xplained MMC device tree updates
@ 2015-03-26 17:38 Ben Dooks
[not found] ` <1427391505-29129-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2015-03-26 17:38 UTC (permalink / raw)
To: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
linux-PelNFVqkFnVyf+4FbqDuWQ, plagnioj-sclMFOaUSTBWk0Htik3J/w
A small set to fix warnings from the kernel.
Note, the atmel_defconfig will require CONFIG_REGULATOR_GPIO
to be set.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread[parent not found: <1427391505-29129-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>]
* [PATCH 1/3] ARM: at91/dt: sama5d3 fill in mmc1 and default disabled [not found] ` <1427391505-29129-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> @ 2015-03-26 17:38 ` Ben Dooks [not found] ` <1427391505-29129-2-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-26 17:38 ` [PATCH 2/3] ARM: at91/dt: sama5d3 add mmc0 vmmcq entry Ben Dooks 2015-03-26 17:38 ` [PATCH 3/3] ARM: at91/dt: sama5d3 add gpio regulator for vmmc0 Ben Dooks 2 siblings, 1 reply; 7+ messages in thread From: Ben Dooks @ 2015-03-26 17:38 UTC (permalink / raw) To: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, linux-PelNFVqkFnVyf+4FbqDuWQ, plagnioj-sclMFOaUSTBWk0Htik3J/w, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King The mmc1 channel is not populated on the SAM5D3 Xplained board, however it is enabled and therefore the driver is attaching to it. The node configuration for mmc1 is missing, so add an mmc1 node in the device tree so add the basic node, set it to default it to disabled. Also add the vmmc and also the necessary slot configuration if this node where to be enabled to avoid the following warnings from the driver. atmel_mci f8000000.mmc: No vmmc regulator found atmel_mci f8000000.mmc: No vqmmc regulator found Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> -- CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org CC: Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org> CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> CC: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> CC: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> CC: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> CC: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> CC: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> CC: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> CC: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts index fec1fca..652c4dd 100644 --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts @@ -43,6 +43,17 @@ }; }; + mmc1: mmc@f8000000 { + vmmc-supply = <&vcc_3v3_reg>; + vqmmc-supply = <&vcc_3v3_reg>; + status = "disabled"; + slot@0 { + reg = <0>; + bus-width = <4>; + cd-gpios = <&pioE 1 GPIO_ACTIVE_LOW>; + }; + }; + spi0: spi@f0004000 { cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; status = "okay"; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1427391505-29129-2-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>]
* Re: [PATCH 1/3] ARM: at91/dt: sama5d3 fill in mmc1 and default disabled [not found] ` <1427391505-29129-2-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> @ 2015-04-21 15:09 ` Ludovic Desroches 0 siblings, 0 replies; 7+ messages in thread From: Ludovic Desroches @ 2015-04-21 15:09 UTC (permalink / raw) To: Ben Dooks Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Pawel Moll, Ian Campbell, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, Rob Herring, Kumar Gala, plagnioj-sclMFOaUSTBWk0Htik3J/w, linux-PelNFVqkFnVyf+4FbqDuWQ On Thu, Mar 26, 2015 at 05:38:23PM +0000, Ben Dooks wrote: > The mmc1 channel is not populated on the SAM5D3 Xplained board, however > it is enabled and therefore the driver is attaching to it. > > The node configuration for mmc1 is missing, so add an mmc1 node in the > device tree so add the basic node, set it to default it to disabled. Also > add the vmmc and also the necessary slot configuration if this node > where to be enabled to avoid the following warnings from the driver. > > atmel_mci f8000000.mmc: No vmmc regulator found > atmel_mci f8000000.mmc: No vqmmc regulator found > > Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> Acked-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> > -- > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > CC: Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org> > CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> > CC: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> > CC: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > CC: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > CC: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > CC: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > CC: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > CC: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index fec1fca..652c4dd 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -43,6 +43,17 @@ > }; > }; > > + mmc1: mmc@f8000000 { > + vmmc-supply = <&vcc_3v3_reg>; > + vqmmc-supply = <&vcc_3v3_reg>; > + status = "disabled"; > + slot@0 { > + reg = <0>; > + bus-width = <4>; > + cd-gpios = <&pioE 1 GPIO_ACTIVE_LOW>; > + }; > + }; > + > spi0: spi@f0004000 { > cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; > status = "okay"; > -- > 2.1.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] ARM: at91/dt: sama5d3 add mmc0 vmmcq entry [not found] ` <1427391505-29129-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-26 17:38 ` [PATCH 1/3] ARM: at91/dt: sama5d3 fill in mmc1 and default disabled Ben Dooks @ 2015-03-26 17:38 ` Ben Dooks [not found] ` <1427391505-29129-3-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-26 17:38 ` [PATCH 3/3] ARM: at91/dt: sama5d3 add gpio regulator for vmmc0 Ben Dooks 2 siblings, 1 reply; 7+ messages in thread From: Ben Dooks @ 2015-03-26 17:38 UTC (permalink / raw) To: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, linux-PelNFVqkFnVyf+4FbqDuWQ, plagnioj-sclMFOaUSTBWk0Htik3J/w, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King The SAM5D3 Xplained device tree is missing hte vqmmc node which is tied to 3.3V on the board. Add this to avoid the kernel warning that there is no vqmmc node. atmel_mci f0000000.mmc: No vqmmc regulator found Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> -- CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org CC: Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org> CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> CC: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> CC: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> CC: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> CC: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> CC: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> CC: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> CC: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts index 652c4dd..1eb150d 100644 --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts @@ -36,6 +36,7 @@ mmc0: mmc@f0000000 { pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>; status = "okay"; + vqmmc-supply = <&vcc_3v3_reg>; slot@0 { reg = <0>; bus-width = <8>; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1427391505-29129-3-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>]
* Re: [PATCH 2/3] ARM: at91/dt: sama5d3 add mmc0 vmmcq entry [not found] ` <1427391505-29129-3-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> @ 2015-04-21 15:13 ` Ludovic Desroches 0 siblings, 0 replies; 7+ messages in thread From: Ludovic Desroches @ 2015-04-21 15:13 UTC (permalink / raw) To: Ben Dooks Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Pawel Moll, Ian Campbell, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, Rob Herring, Kumar Gala, plagnioj-sclMFOaUSTBWk0Htik3J/w, linux-PelNFVqkFnVyf+4FbqDuWQ On Thu, Mar 26, 2015 at 05:38:24PM +0000, Ben Dooks wrote: > The SAM5D3 Xplained device tree is missing hte vqmmc node which is > tied to 3.3V on the board. Add this to avoid the kernel warning that > there is no vqmmc node. > > atmel_mci f0000000.mmc: No vqmmc regulator found > > Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> > -- > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > CC: Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org> > CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> > CC: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> > CC: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > CC: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > CC: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > CC: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > CC: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > CC: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index 652c4dd..1eb150d 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -36,6 +36,7 @@ > mmc0: mmc@f0000000 { > pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>; > status = "okay"; > + vqmmc-supply = <&vcc_3v3_reg>; above status would be better, usually we keep status at the latest property even if in this cas we have slot after... Otherwise Acked-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> > slot@0 { > reg = <0>; > bus-width = <8>; > -- > 2.1.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: at91/dt: sama5d3 add gpio regulator for vmmc0 [not found] ` <1427391505-29129-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2015-03-26 17:38 ` [PATCH 1/3] ARM: at91/dt: sama5d3 fill in mmc1 and default disabled Ben Dooks 2015-03-26 17:38 ` [PATCH 2/3] ARM: at91/dt: sama5d3 add mmc0 vmmcq entry Ben Dooks @ 2015-03-26 17:38 ` Ben Dooks [not found] ` <1427391505-29129-4-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> 2 siblings, 1 reply; 7+ messages in thread From: Ben Dooks @ 2015-03-26 17:38 UTC (permalink / raw) To: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, linux-PelNFVqkFnVyf+4FbqDuWQ, plagnioj-sclMFOaUSTBWk0Htik3J/w, Ben Dooks, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King Add gpio regulator for vmmc0 and attach the vmmc for it to the mmc0 node on the SAM5D3 Xplained board. This will remove the following warning from the kernel: atmel_mci f0000000.mmc: No vmmc regulator found Note, atmel_defconfig will need gpio regulator support enabled if this is to be used properly. Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> -- CC: Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org> CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> CC: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> CC: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> CC: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> CC: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> CC: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> CC: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> CC: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts index 1eb150d..6b6ad5c 100644 --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts @@ -36,6 +36,7 @@ mmc0: mmc@f0000000 { pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>; status = "okay"; + vmmc-supply = <&vcc_mmc0_reg>; vqmmc-supply = <&vcc_3v3_reg>; slot@0 { reg = <0>; @@ -285,6 +286,14 @@ }; }; + vcc_mmc0_reg: regulator@1 { + compatible = "regualtor-gpio"; + gpio = <&pioE 2 GPIO_ACTIVE_LOW>; + regulator-name = "mmc0-card-supply"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + gpio_keys { compatible = "gpio-keys"; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1427391505-29129-4-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>]
* Re: [PATCH 3/3] ARM: at91/dt: sama5d3 add gpio regulator for vmmc0 [not found] ` <1427391505-29129-4-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> @ 2015-04-21 15:14 ` Ludovic Desroches 0 siblings, 0 replies; 7+ messages in thread From: Ludovic Desroches @ 2015-04-21 15:14 UTC (permalink / raw) To: Ben Dooks Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Pawel Moll, Ian Campbell, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, Rob Herring, Kumar Gala, plagnioj-sclMFOaUSTBWk0Htik3J/w, linux-PelNFVqkFnVyf+4FbqDuWQ On Thu, Mar 26, 2015 at 05:38:25PM +0000, Ben Dooks wrote: > Add gpio regulator for vmmc0 and attach the vmmc for it to the mmc0 > node on the SAM5D3 Xplained board. This will remove the following > warning from the kernel: > > atmel_mci f0000000.mmc: No vmmc regulator found > > Note, atmel_defconfig will need gpio regulator support enabled if this > is to be used properly. > > Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> > -- > CC: Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org> > CC: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> > CC: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> > CC: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > CC: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > CC: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > CC: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > CC: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > CC: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index 1eb150d..6b6ad5c 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -36,6 +36,7 @@ > mmc0: mmc@f0000000 { > pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>; > status = "okay"; > + vmmc-supply = <&vcc_mmc0_reg>; > vqmmc-supply = <&vcc_3v3_reg>; > slot@0 { > reg = <0>; > @@ -285,6 +286,14 @@ > }; > }; > > + vcc_mmc0_reg: regulator@1 { > + compatible = "regualtor-gpio"; typo here and I think it is a fixed regulator and not a gpio one since we can't configure voltage. > + gpio = <&pioE 2 GPIO_ACTIVE_LOW>; > + regulator-name = "mmc0-card-supply"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > gpio_keys { > compatible = "gpio-keys"; > > -- > 2.1.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-04-21 15:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-26 17:38 SAM5D3 Xplained MMC device tree updates Ben Dooks
[not found] ` <1427391505-29129-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-03-26 17:38 ` [PATCH 1/3] ARM: at91/dt: sama5d3 fill in mmc1 and default disabled Ben Dooks
[not found] ` <1427391505-29129-2-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-04-21 15:09 ` Ludovic Desroches
2015-03-26 17:38 ` [PATCH 2/3] ARM: at91/dt: sama5d3 add mmc0 vmmcq entry Ben Dooks
[not found] ` <1427391505-29129-3-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-04-21 15:13 ` Ludovic Desroches
2015-03-26 17:38 ` [PATCH 3/3] ARM: at91/dt: sama5d3 add gpio regulator for vmmc0 Ben Dooks
[not found] ` <1427391505-29129-4-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2015-04-21 15:14 ` Ludovic Desroches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).