From: Leo Yan <leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Wei Xu <xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
Dan Zhao <dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
zhenwei.wang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
Haojian Zhuang
<haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Bintian Wang
<bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Leo Yan <leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: [PATCH v2 2/5] clk: hisi: add API for allocation clk data struct
Date: Mon, 30 Mar 2015 13:24:21 +0800 [thread overview]
Message-ID: <1427693064-11062-3-git-send-email-leo.yan@linaro.org> (raw)
In-Reply-To: <1427693064-11062-1-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
In the clk init function, it will read the register base address from
dts and allocate the clk data structures. But for the some cases, the
clock driver don't need init the reg's base address, which will directly
access mmio region with syscon.
So for clock's initialization, this patch adds one more API which is
only for allocating clock data structure.
Signed-off-by: Leo Yan <leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/clk/hisilicon/clk.c | 30 +++++++++++++++++++++++-------
drivers/clk/hisilicon/clk.h | 2 ++
2 files changed, 25 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/hisilicon/clk.c b/drivers/clk/hisilicon/clk.c
index 1951b37..87f8173 100644
--- a/drivers/clk/hisilicon/clk.c
+++ b/drivers/clk/hisilicon/clk.c
@@ -38,16 +38,14 @@
static DEFINE_SPINLOCK(hisi_clk_lock);
-struct hisi_clock_data __init *hisi_clk_init(struct device_node *np,
- int nr_clks)
+struct hisi_clock_data __init *hisi_clk_alloc_data(struct device_node *np,
+ int nr_clks)
{
struct hisi_clock_data *clk_data;
struct clk **clk_table;
- void __iomem *base;
- base = of_iomap(np, 0);
- if (!base) {
- pr_err("%s: failed to map clock registers\n", __func__);
+ if (!np) {
+ pr_err("%s: invalid device node handler\n", __func__);
goto err;
}
@@ -56,7 +54,6 @@ struct hisi_clock_data __init *hisi_clk_init(struct device_node *np,
pr_err("%s: could not allocate clock data\n", __func__);
goto err;
}
- clk_data->base = base;
clk_table = kzalloc(sizeof(struct clk *) * nr_clks, GFP_KERNEL);
if (!clk_table) {
@@ -67,12 +64,31 @@ struct hisi_clock_data __init *hisi_clk_init(struct device_node *np,
clk_data->clk_data.clk_num = nr_clks;
of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data->clk_data);
return clk_data;
+
err_data:
kfree(clk_data);
err:
return NULL;
}
+struct hisi_clock_data __init *hisi_clk_init(struct device_node *np,
+ int nr_clks)
+{
+ struct hisi_clock_data *clk_data;
+ void __iomem *base;
+
+ base = of_iomap(np, 0);
+ if (!base) {
+ pr_err("%s: failed to map clock registers\n", __func__);
+ return NULL;
+ }
+
+ clk_data = hisi_clk_alloc_data(np, nr_clks);
+ if (clk_data)
+ clk_data->base = base;
+ return clk_data;
+}
+
void __init hisi_clk_register_fixed_rate(struct hisi_fixed_rate_clock *clks,
int nums, struct hisi_clock_data *data)
{
diff --git a/drivers/clk/hisilicon/clk.h b/drivers/clk/hisilicon/clk.h
index 31083ff..624f608 100644
--- a/drivers/clk/hisilicon/clk.h
+++ b/drivers/clk/hisilicon/clk.h
@@ -96,6 +96,8 @@ struct clk *hisi_register_clkgate_sep(struct device *, const char *,
u8, spinlock_t *);
struct hisi_clock_data __init *hisi_clk_init(struct device_node *, int);
+struct hisi_clock_data __init *hisi_clk_alloc_data(struct device_node *np,
+ int nr_clks);
void __init hisi_clk_register_fixed_rate(struct hisi_fixed_rate_clock *,
int, struct hisi_clock_data *);
void __init hisi_clk_register_fixed_factor(struct hisi_fixed_factor_clock *,
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-30 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 5:24 [PATCH v2 0/5] clk: hisilicon: support stub clock Leo Yan
[not found] ` <1427693064-11062-1-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-03-30 5:24 ` [PATCH v2 1/5] clk: hisi: refine parameter checking for init Leo Yan
2015-03-30 5:24 ` Leo Yan [this message]
2015-03-30 5:24 ` [PATCH v2 3/5] dt-bindings: clk: hisilicon: Document stub clock driver Leo Yan
2015-03-30 5:24 ` [PATCH v2 4/5] clk: hisi: add stub clk driver Leo Yan
2015-03-30 5:24 ` [PATCH v2 5/5] clk: hisi: add stub clock register function Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427693064-11062-3-git-send-email-leo.yan@linaro.org \
--to=leo.yan-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=zhenwei.wang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).