devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org, linux-media@vger.kernel.org
Cc: kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com,
	rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	devicetree@vger.kernel.org
Subject: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties
Date: Tue, 31 Mar 2015 15:52:37 +0200	[thread overview]
Message-ID: <1427809965-25540-2-git-send-email-j.anaszewski@samsung.com> (raw)
In-Reply-To: <1427809965-25540-1-git-send-email-j.anaszewski@samsung.com>

Description of flash LEDs related properties was not precise regarding
the state of corresponding settings in case a property is missing.
Add relevant statements.
Removed is also the requirement making the flash-max-microamp
property obligatory for flash LEDs. It was inconsistent as the property
is defined as optional. Devices which require the property will have
to assert this in their DT bindings.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: devicetree@vger.kernel.org
---
 Documentation/devicetree/bindings/leds/common.txt |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index 747c538..21a25e4 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -29,13 +29,15 @@ Optional properties for child nodes:
      "ide-disk" - LED indicates disk activity
      "timer" - LED flashes at a fixed, configurable rate
 
-- max-microamp : maximum intensity in microamperes of the LED
-		 (torch LED for flash devices)
-- flash-max-microamp : maximum intensity in microamperes of the
-                       flash LED; it is mandatory if the LED should
-		       support the flash mode
-- flash-timeout-us : timeout in microseconds after which the flash
-                     LED is turned off
+- max-microamp : Maximum intensity in microamperes of the LED
+		 (torch LED for flash devices). If omitted this will default
+		 to the maximum current allowed by the device.
+- flash-max-microamp : Maximum intensity in microamperes of the flash LED.
+		       If omitted this will default to the maximum
+		       current allowed by the device.
+- flash-timeout-us : Timeout in microseconds after which the flash
+                     LED is turned off. If omitted this will default to the
+		     maximum timeout allowed by the device.
 
 
 Examples:
-- 
1.7.9.5

       reply	other threads:[~2015-03-31 13:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1427809965-25540-1-git-send-email-j.anaszewski@samsung.com>
2015-03-31 13:52 ` Jacek Anaszewski [this message]
2015-04-02 14:41   ` [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties Pavel Machek
2015-04-03 12:09   ` Sakari Ailus
2015-04-03 12:56     ` Jacek Anaszewski
2015-04-03 20:37       ` Pavel Machek
2015-04-08  1:20         ` Bryan Wu
     [not found]           ` <CAK5ve-KR81cNrJnPj_XUkNvctsEYLDGb58qTVaOOAYJnoZTGXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-08  7:48             ` Sakari Ailus
2015-04-08  9:13           ` Pavel Machek
2015-04-08  8:54     ` Jacek Anaszewski
2015-04-08  9:11       ` Sakari Ailus
2015-04-08  9:17         ` Pavel Machek
2015-04-08 10:23         ` Jacek Anaszewski
     [not found]           ` <5525019B.8050104-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-04-08 10:44             ` Sakari Ailus
2015-04-08 10:03   ` Sylwester Nawrocki
2015-04-08 10:36     ` Pavel Machek
2015-04-08 11:58     ` Jacek Anaszewski
2015-04-08 14:45       ` Sylwester Nawrocki
2015-03-31 13:52 ` [PATCH v4 04/12] DT: Add documentation for the mfd Maxim max77693 Jacek Anaszewski
     [not found]   ` <1427809965-25540-5-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-03-31 14:34     ` Jacek Anaszewski
2015-03-31 13:52 ` [PATCH v4 06/12] of: Add Skyworks Solutions, Inc. vendor prefix Jacek Anaszewski
2015-04-08 11:59   ` Sakari Ailus
2015-03-31 13:52 ` [PATCH v4 07/12] DT: Add documentation for the Skyworks AAT1290 Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427809965-25540-2-git-send-email-j.anaszewski@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=cooloney@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=s.nawrocki@samsung.com \
    --cc=sakari.ailus@iki.fi \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).