* [PATCH v2] ARM: dts: mt8173: support arm64 cpuidle-dt
@ 2015-04-07 8:05 Howard Chen
[not found] ` <1428393905-32166-1-git-send-email-howard.chen-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Howard Chen @ 2015-04-07 8:05 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Catalin Marinas, Will Deacon, Howard Chen, Eddie Huang,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
srv_heupstream, Sascha Hauer
This patch adds an idle-states node to describe the mt8173 idle states and
also adds references to the idle-states node in all CPU nodes.
Signed-off-by: Howard Chen <howard.chen@linaro.org>
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 8554ec3..0d31a34 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -48,6 +48,8 @@
device_type = "cpu";
compatible = "arm,cortex-a53";
reg = <0x000>;
+ enable-method = "psci";
+ cpu-idle-states = <&CPU_SLEEP_0>;
};
cpu1: cpu@1 {
@@ -55,6 +57,7 @@
compatible = "arm,cortex-a53";
reg = <0x001>;
enable-method = "psci";
+ cpu-idle-states = <&CPU_SLEEP_0>;
};
cpu2: cpu@100 {
@@ -62,6 +65,7 @@
compatible = "arm,cortex-a57";
reg = <0x100>;
enable-method = "psci";
+ cpu-idle-states = <&CPU_SLEEP_0>;
};
cpu3: cpu@101 {
@@ -69,6 +73,19 @@
compatible = "arm,cortex-a57";
reg = <0x101>;
enable-method = "psci";
+ cpu-idle-states = <&CPU_SLEEP_0>;
+ };
+
+ idle-states {
+ entry-method = "arm,psci";
+
+ CPU_SLEEP_0: cpu-sleep-0 {
+ compatible = "arm,idle-state";
+ arm,psci-suspend-param = <0x0010000>;
+ entry-latency-us = <639>;
+ exit-latency-us = <328>;
+ min-residency-us = <1088>;
+ };
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <1428393905-32166-1-git-send-email-howard.chen-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* Re: [PATCH v2] ARM: dts: mt8173: support arm64 cpuidle-dt [not found] ` <1428393905-32166-1-git-send-email-howard.chen-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> @ 2015-04-08 10:54 ` Lorenzo Pieralisi 0 siblings, 0 replies; 2+ messages in thread From: Lorenzo Pieralisi @ 2015-04-08 10:54 UTC (permalink / raw) To: Howard Chen Cc: Matthias Brugger, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Catalin Marinas, Will Deacon, Eddie Huang, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sascha Hauer On Tue, Apr 07, 2015 at 09:05:05AM +0100, Howard Chen wrote: > This patch adds an idle-states node to describe the mt8173 idle states and > also adds references to the idle-states node in all CPU nodes. > > Signed-off-by: Howard Chen <howard.chen-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Is copying me in too much effort to ask ? > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 8554ec3..0d31a34 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -48,6 +48,8 @@ > device_type = "cpu"; > compatible = "arm,cortex-a53"; > reg = <0x000>; > + enable-method = "psci"; > + cpu-idle-states = <&CPU_SLEEP_0>; Cluster idle state vanished between v1 and v2. ? > }; > > cpu1: cpu@1 { > @@ -55,6 +57,7 @@ > compatible = "arm,cortex-a53"; > reg = <0x001>; > enable-method = "psci"; > + cpu-idle-states = <&CPU_SLEEP_0>; > }; > > cpu2: cpu@100 { > @@ -62,6 +65,7 @@ > compatible = "arm,cortex-a57"; > reg = <0x100>; > enable-method = "psci"; > + cpu-idle-states = <&CPU_SLEEP_0>; > }; > > cpu3: cpu@101 { > @@ -69,6 +73,19 @@ > compatible = "arm,cortex-a57"; > reg = <0x101>; > enable-method = "psci"; > + cpu-idle-states = <&CPU_SLEEP_0>; > + }; > + > + idle-states { > + entry-method = "arm,psci"; > + > + CPU_SLEEP_0: cpu-sleep-0 { > + compatible = "arm,idle-state"; > + arm,psci-suspend-param = <0x0010000>; > + entry-latency-us = <639>; > + exit-latency-us = <328>; > + min-residency-us = <1088>; > + }; > }; > }; Is the arch timer still running when you enter this state ? Apart from these remarks the patch seems fine, I wonder whether we should merge these changes into the kernel instead of keeping these changes in firmware for specific kernel configurations. Lorenzo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-08 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-07 8:05 [PATCH v2] ARM: dts: mt8173: support arm64 cpuidle-dt Howard Chen
[not found] ` <1428393905-32166-1-git-send-email-howard.chen-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-04-08 10:54 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).