[PATCH] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[PATCH] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman]

From: Igal Liberman <Igal.Liberman@freescale.com>

Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
---
 .../devicetree/bindings/clock/qoriq-clock.txt      |   59 ++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
index df4a259..a7e84ce 100644
--- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
+++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
@@ -65,6 +65,7 @@ Required properties:
 		It takes parent's clock-frequency as its clock.
 	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
 	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
+	* "fsl,fman-clk-mux" for the Frame Manager clock.
 - #clock-cells: From common clock binding. The number of cells in a
 	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
 	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
@@ -73,6 +74,52 @@ Required properties:
 	* 0 - equal to the PLL frequency
 	* 1 - equal to the PLL frequency divided by 2
 	* 2 - equal to the PLL frequency divided by 4
+	For "fsl,fman-clk-mux" clocks, the single clock-specifier cell may
+	take values according the Reset Configuration Word of the specific
+	device:
+		* P2041, P3041:
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL2 divided by 2
+		* P4080 (Both FMans):
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL3 divided by 2
+		* P5020:
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL2 divided by 2
+			* 2 - equal to PLL2 divided by 4
+		* P5040 (Both FMans):
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL3 divided by 2
+			* 2 - equal to PLL3 divided by 4
+		* T1024:
+			* 0 - equal to PLL1 divided by 2
+		* T1040:
+			* 0 - equal to platform PLL
+		* T2080, B4860, B4420:
+			* 0 - equal to PLL1
+			* 1 - equal to PLL1 divided by 2
+			* 2 - equal to PLL1 divided by 3
+			* 3 - equal to PLL1 divided by 4
+			* 4 - equal to platform PLL
+			* 5 - equal to PLL2 divided by 2
+			* 6 - equal to PLL2 divided by 3
+		* T4240:
+			* FM1:
+			* 0 equal to PLL1 divided by 2
+			* 1 equal to PLL1 divided by 3
+			* 2 equal to PLL1 divided by 4
+			* 3 equal to platform PLL
+			* 4 equal to PLL2 divided by 2
+			* FM2:
+			* 0 equal to PLL2 divided by 2
+			* 1 equal to PLL2 divided by 3
+			* 2 equal to PLL2 divided by 4
+			* 3 equal to platform PLL
+			* 4 equal to PLL1 divided by 2
+			* 5 equal to PLL1 divided by 3
+		In Part of FMan V3 devices (B4, T2, T4) the single
+		clock-specifier cell may be determined by the CLKCGxHWACSR
+		register in addtion to RCW.
 
 Recommended properties:
 - clocks: Should be the phandle of input parent clock
@@ -139,6 +186,18 @@ Example for clock block and clock provider:
 			clocks = <&sysclk>;
 			clock-output-names = "platform-pll", "platform-pll-div2";
 		};
+
+		fm0clk: fm0-clk-mux {
+			#clock-cells = <0>;
+			reg = <0x10 4>
+			compatible = "fsl,fman-clk-mux";
+			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
+				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
+			clock-names = "pll0", "pll0-div2", "pll0-div3",
+				      "pll0-div4", "platform-pll", "pll1-div2",
+				      "pll1-div3";
+			clock-output-names = "fm0-clk";
+		};
 	};
 };
 
-- 
1.7.9.5

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Tue, 2015-04-07 at 07:08 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  .../devicetree/bindings/clock/qoriq-clock.txt      |   59 ++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> index df4a259..a7e84ce 100644
> --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> @@ -65,6 +65,7 @@ Required properties:
>  		It takes parent's clock-frequency as its clock.
>  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
>  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> +	* "fsl,fman-clk-mux" for the Frame Manager clock.

Is there any versioning required on this?

>  - #clock-cells: From common clock binding. The number of cells in a
>  	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
>  	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> @@ -73,6 +74,52 @@ Required properties:
>  	* 0 - equal to the PLL frequency
>  	* 1 - equal to the PLL frequency divided by 2
>  	* 2 - equal to the PLL frequency divided by 4
> +	For "fsl,fman-clk-mux" clocks, the single clock-specifier cell may
> +	take values according the Reset Configuration Word of the specific
> +	device:

fsl,fman-clk-mux nodes have #clock-cells of zero, so I don't understand
this section.

If this is meant to refer to the clock specifier that fsl,fman-clk-mux
nodes use in their input clocks, that is determined by the clock
provider and not the clock consumer.  

-Scott


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

RE: [PATCH] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Igal.Liberman-KZfg59tc24xl57MIdRCFDg]

Hi Scott

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, April 08, 2015 1:40 AM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] dt/bindings: qoriq-clock: Add binding for FMan clock
> mux
> 
> On Tue, 2015-04-07 at 07:08 +0300, Igal.Liberman wrote:
> > From: Igal Liberman <Igal.Liberman@freescale.com>
> >
> > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > ---
> >  .../devicetree/bindings/clock/qoriq-clock.txt      |   59
> ++++++++++++++++++++
> >  1 file changed, 59 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > index df4a259..a7e84ce 100644
> > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > @@ -65,6 +65,7 @@ Required properties:
> >  		It takes parent's clock-frequency as its clock.
> >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> 
> Is there any versioning required on this?
> 

I don't think we need versioning here.

> >  - #clock-cells: From common clock binding. The number of cells in a
> >  	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
> >  	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
> > @@ -73,6 +74,52 @@ Required properties:
> >  	* 0 - equal to the PLL frequency
> >  	* 1 - equal to the PLL frequency divided by 2
> >  	* 2 - equal to the PLL frequency divided by 4
> > +	For "fsl,fman-clk-mux" clocks, the single clock-specifier cell may
> > +	take values according the Reset Configuration Word of the specific
> > +	device:
> 
> fsl,fman-clk-mux nodes have #clock-cells of zero, so I don't understand this
> section.
> 
> If this is meant to refer to the clock specifier that fsl,fman-clk-mux nodes use
> in their input clocks, that is determined by the clock provider and not the
> clock consumer.
> 

This section refers to the clock provider.
I need to move the text bellow to more appropriate place, not under #clock-cells. 
Any comments on the content itself? 

> -Scott
> 

Thanks, Igal

Re: [PATCH] dt/bindings: qoriq-clock: Add binding for FMan clock mux

[Scott Wood]

On Wed, 2015-04-08 at 03:54 -0500, Liberman Igal-B31950 wrote:
> Hi Scott
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, April 08, 2015 1:40 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > Subject: Re: [PATCH] dt/bindings: qoriq-clock: Add binding for FMan clock
> > mux
> > 
> > On Tue, 2015-04-07 at 07:08 +0300, Igal.Liberman wrote:
> > > From: Igal Liberman <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > >
> > > Signed-off-by: Igal Liberman <Igal.Liberman-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > > ---
> > >  .../devicetree/bindings/clock/qoriq-clock.txt      |   59
> > ++++++++++++++++++++
> > >  1 file changed, 59 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > index df4a259..a7e84ce 100644
> > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > @@ -65,6 +65,7 @@ Required properties:
> > >  		It takes parent's clock-frequency as its clock.
> > >  	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
> > >  	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
> > > +	* "fsl,fman-clk-mux" for the Frame Manager clock.
> > 
> > Is there any versioning required on this?
> > 
> 
> I don't think we need versioning here.

Even though we needed it on the other nodes?

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html