From: Florian Fainelli <f.fainelli@gmail.com>
To: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
grant.likely@linaro.org, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH] of/flattree: print memory scan node results in CPU endian
Date: Tue, 7 Apr 2015 23:44:10 -0700 [thread overview]
Message-ID: <1428475450-12072-1-git-send-email-f.fainelli@gmail.com> (raw)
Commit 51975db0b7333 ("of/flattree: merge early_init_dt_scan_memory()
common code") consolidated some code from PowerPC (typically
big-endian), and ended-up adding a pr_debug() printing reg properties in
big-endian (DT native) format, not CPU endian. Unsurprisingly, when
these messages are turned on a little-endian systems, this is confusing,
so do the conversion while printing the values.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/of/fdt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 3a896c9aeb74..0d8f0e4bd107 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -880,7 +880,8 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname,
endp = reg + (l / sizeof(__be32));
pr_debug("memory scan node %s, reg size %d, data: %x %x %x %x,\n",
- uname, l, reg[0], reg[1], reg[2], reg[3]);
+ uname, l, be32_to_cpu(reg[0]), be32_to_cpu(reg[1]),
+ be32_to_cpu(reg[2]), be32_to_cpu(reg[3]));
while ((endp - reg) >= (dt_root_addr_cells + dt_root_size_cells)) {
u64 base, size;
--
2.1.0
next reply other threads:[~2015-04-08 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 6:44 Florian Fainelli [this message]
2015-04-08 21:19 ` [PATCH] of/flattree: print memory scan node results in CPU endian Frank Rowand
[not found] ` <55259B4D.2020304-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-09 3:17 ` Florian Fainelli
2015-04-12 20:16 ` [PATCH] of/fdt: Remove "reg" data prints from early_init_dt_scan_memory Florian Fainelli
[not found] ` <1428869786-26897-1-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-15 12:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428475450-12072-1-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).