From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Pavel Machek <pavel@ucw.cz>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
devicetree@vger.kernel.org
Subject: [PATCH v5] DT: leds: Improve description of flash LEDs related properties
Date: Wed, 08 Apr 2015 16:31:27 +0200 [thread overview]
Message-ID: <1428503487-4912-1-git-send-email-j.anaszewski@samsung.com> (raw)
Properties defining maximum values for LED currents and timeout should
be mandatory to avoid the risk of hardware damage. This patch fixes
the issue.
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org
---
Documentation/devicetree/bindings/leds/common.txt | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index 747c538..e478ac6 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -10,6 +10,17 @@ can influence the way of the LED device initialization, the LED components
have to be tightly coupled with the LED device binding. They are represented
by child nodes of the parent LED device binding.
+Required properties for child nodes:
+- led-max-microamp : Maximum LED supply current in microamperes
+ (torch LED for flash devices). Controllers that have no
+ configurable current can omit this property.
+- flash-max-microamp : Maximum flash LED supply current in microamperes.
+- flash-timeout-us : Timeout in microseconds after which the flash
+ LED is turned off.
+
+Above properties determine a LED driver IC settings required for safe
+operation. They should be also used as the initial settings for the IC.
+
Optional properties for child nodes:
- led-sources : List of device current outputs the LED is connected to. The
outputs are identified by the numbers that must be defined
@@ -29,14 +40,6 @@ Optional properties for child nodes:
"ide-disk" - LED indicates disk activity
"timer" - LED flashes at a fixed, configurable rate
-- max-microamp : maximum intensity in microamperes of the LED
- (torch LED for flash devices)
-- flash-max-microamp : maximum intensity in microamperes of the
- flash LED; it is mandatory if the LED should
- support the flash mode
-- flash-timeout-us : timeout in microseconds after which the flash
- LED is turned off
-
Examples:
--
1.7.9.5
next reply other threads:[~2015-04-08 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 14:31 Jacek Anaszewski [this message]
2015-04-08 15:15 ` [PATCH v5] DT: leds: Improve description of flash LEDs related properties Sylwester Nawrocki
2015-04-09 7:23 ` Jacek Anaszewski
2015-04-09 8:03 ` Sakari Ailus
2015-04-09 10:03 ` Sylwester Nawrocki
2015-04-09 14:39 ` Jacek Anaszewski
2015-04-09 23:25 ` Sakari Ailus
2015-04-09 9:45 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428503487-4912-1-git-send-email-j.anaszewski@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).