[PATCH] dt/bindings: fsl/guts: Added global-utilities compatibles

[PATCH] dt/bindings: fsl/guts: Added global-utilities compatibles

[Igal.Liberman]

From: Igal Liberman <Igal.Liberman@freescale.com>

Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
---
 .../devicetree/bindings/powerpc/fsl/guts.txt       |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
index 7f150b5..e4f0ac2 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
@@ -9,6 +9,20 @@ Required properties:
 
  - compatible : Should define the compatible device type for
    global-utilities.
+   Possible compatibles:
+	"fsl,qoriq-device-config-1.0"
+	"fsl,p2041-device-config"
+	"fsl,p3041-device-config"
+	"fsl,p4080-device-config"
+	"fsl,p5020-device-config"
+	"fsl,p5040-device-config"
+	"fsl,qoriq-device-config-2.0"
+	"fsl,b4860-device-config"
+	"fsl,b4420-device-config"
+	"fsl,b4-device-config"
+	"fsl,t1040-device-config"
+	"fsl,t2080-device-config"
+	"fsl,t4240-device-config"
  - reg : Offset and length of the register set for the device.
 
 Recommended properties:
-- 
1.7.9.5

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] dt/bindings: fsl/guts: Added global-utilities compatibles

[Scott Wood]

On Thu, 2015-04-09 at 09:19 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  .../devicetree/bindings/powerpc/fsl/guts.txt       |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> index 7f150b5..e4f0ac2 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> @@ -9,6 +9,20 @@ Required properties:
>  
>   - compatible : Should define the compatible device type for
>     global-utilities.
> +   Possible compatibles:
> +	"fsl,qoriq-device-config-1.0"
> +	"fsl,p2041-device-config"
> +	"fsl,p3041-device-config"
> +	"fsl,p4080-device-config"
> +	"fsl,p5020-device-config"
> +	"fsl,p5040-device-config"
> +	"fsl,qoriq-device-config-2.0"
> +	"fsl,b4860-device-config"
> +	"fsl,b4420-device-config"
> +	"fsl,b4-device-config"
> +	"fsl,t1040-device-config"
> +	"fsl,t2080-device-config"
> +	"fsl,t4240-device-config"

There's no need to list every chip here.  Just list the ones that aren't
chips, plus "fsl,<chip>-device-config".

As for fsl,b4-device-config, does that exist in any final dtb (as
opposed to b4si-post.dtsi)?  The b4420 and b4860 dtsi files both
overwrite that compatible.

-Scott


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

RE: [PATCH] dt/bindings: fsl/guts: Added global-utilities compatibles

[Igal.Liberman]

Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, April 09, 2015 8:00 PM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] dt/bindings: fsl/guts: Added global-utilities compatibles
> 
> On Thu, 2015-04-09 at 09:19 +0300, Igal.Liberman wrote:
> > From: Igal Liberman <Igal.Liberman@freescale.com>
> >
> > Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> > ---
> >  .../devicetree/bindings/powerpc/fsl/guts.txt       |   14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > index 7f150b5..e4f0ac2 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > @@ -9,6 +9,20 @@ Required properties:
> >
> >   - compatible : Should define the compatible device type for
> >     global-utilities.
> > +   Possible compatibles:
> > +	"fsl,qoriq-device-config-1.0"
> > +	"fsl,p2041-device-config"
> > +	"fsl,p3041-device-config"
> > +	"fsl,p4080-device-config"
> > +	"fsl,p5020-device-config"
> > +	"fsl,p5040-device-config"
> > +	"fsl,qoriq-device-config-2.0"
> > +	"fsl,b4860-device-config"
> > +	"fsl,b4420-device-config"
> > +	"fsl,b4-device-config"
> > +	"fsl,t1040-device-config"
> > +	"fsl,t2080-device-config"
> > +	"fsl,t4240-device-config"
> 
> There's no need to list every chip here.  Just list the ones that aren't chips,
> plus "fsl,<chip>-device-config".
> 

Ok. 

> As for fsl,b4-device-config, does that exist in any final dtb (as opposed to
> b4si-post.dtsi)?  The b4420 and b4860 dtsi files both overwrite that
> compatible.
> 

Currently "fsl,b4-device-config" doesn't exists in any final dtb. We can drop it.

> -Scott
> 

Igal
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev