Re: [PATCH] powerpc/dts: Update the core cluster PLL node(s)

[Scott Wood <scottwood@freescale.com>]

On Tue, 2015-04-14 at 12:55 +0300, Igal.Liberman wrote:
> From: Igal Liberman <Igal.Liberman@freescale.com>
> 
> This patch replaces the following:
> 	https://patchwork.ozlabs.org/patch/427664/
> 
> This patch is described by the following binding document update:
> 	https://patchwork.ozlabs.org/patch/461150/
> 
> Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
> ---
>  arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> index 48e0b6e..7e1f074 100644
> --- a/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi
> @@ -49,14 +49,16 @@ global-utilities@e1000 {
>  		reg = <0x800 0x4>;
>  		compatible = "fsl,qoriq-core-pll-2.0";
>  		clocks = <&sysclk>;
> -		clock-output-names = "pll0", "pll0-div2", "pll0-div4";
> +		clock-output-names = "pll0", "pll0-div2", "pll0-div3",
> +				      "pll0-div4";
>  	};
>  	pll1: pll1@820 {
>  		#clock-cells = <1>;
>  		reg = <0x820 0x4>;
>  		compatible = "fsl,qoriq-core-pll-2.0";
>  		clocks = <&sysclk>;
> -		clock-output-names = "pll1", "pll1-div2", "pll1-div4";
> +		clock-output-names = "pll1", "pll1-div2", "pll1-div3",
> +				      "pll1-div4";

Wait, so if the driver implements the binding you submitted, you'll
break compatibility with these older device trees...

I think we need to just accept the ugly count-the-clock-names approach
and document it.

-Scott


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev