From: Ding Tianhong <dingtianhong@huawei.com>
To: arnd@arndb.de, davem@davemloft.net, grant.likely@linaro.org
Cc: sergei.shtylyov@cogentembedded.com,
linux-arm-kernel@lists.infradead.org, eric.dumazet@gmail.com,
zhangfei.gao@linaro.org, joe@perches.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux@arm.linux.org.uk
Subject: [PATCH net-next 1/6] net: hip04: Set more appropriate value for tx coalesce num
Date: Wed, 15 Apr 2015 20:30:03 +0800 [thread overview]
Message-ID: <1429101008-9464-2-git-send-email-dingtianhong@huawei.com> (raw)
In-Reply-To: <1429101008-9464-1-git-send-email-dingtianhong@huawei.com>
According Arnd's suggestion, the user might set the tx coalesce value
in large range for different workloads, so we should define them to
appropriate value.
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Joe Perches <joe@perches.com>
---
drivers/net/ethernet/hisilicon/hip04_eth.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
index b72d238..b0a7f03 100644
--- a/drivers/net/ethernet/hisilicon/hip04_eth.c
+++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
@@ -126,10 +126,10 @@
#define DRV_NAME "hip04-ether"
#define DRV_VERSION "v1.0"
-#define HIP04_MAX_TX_COALESCE_USECS 200
-#define HIP04_MIN_TX_COALESCE_USECS 100
-#define HIP04_MAX_TX_COALESCE_FRAMES 200
-#define HIP04_MIN_TX_COALESCE_FRAMES 100
+#define HIP04_MAX_TX_COALESCE_USECS 100000
+#define HIP04_MIN_TX_COALESCE_USECS 1
+#define HIP04_MAX_TX_COALESCE_FRAMES (TX_DESC_NUM - 1)
+#define HIP04_MIN_TX_COALESCE_FRAMES 1
struct tx_desc {
u32 send_addr;
--
1.8.0
next prev parent reply other threads:[~2015-04-15 12:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 12:30 [PATCH net-next 0/6] net: hip04: fix some problem for hip04 drivers Ding Tianhong
2015-04-15 12:30 ` Ding Tianhong [this message]
2015-04-15 14:11 ` [PATCH net-next 1/6] net: hip04: Set more appropriate value for tx coalesce num Arnd Bergmann
2015-04-15 12:30 ` [PATCH net-next 4/6] net: hip04: Don't free the tx skb when the buffer is not ready for xmit Ding Tianhong
2015-04-15 14:19 ` Arnd Bergmann
2015-04-16 6:26 ` Ding Tianhong
2015-04-16 8:41 ` Arnd Bergmann
2015-04-16 9:38 ` Ding Tianhong
[not found] ` <1429101008-9464-1-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 12:30 ` [PATCH net-next 2/6] net: hip04: use the big endian for tx and rx desc Ding Tianhong
[not found] ` <1429101008-9464-3-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 14:13 ` Arnd Bergmann
2015-04-16 6:25 ` Ding Tianhong
2015-04-15 12:30 ` [PATCH net-next 3/6] net: hip04: Solve the problem of the skb memory allocation failure Ding Tianhong
[not found] ` <1429101008-9464-4-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 14:17 ` Arnd Bergmann
2015-04-15 12:30 ` [PATCH net-next 5/6] net: hip04: remove the unnecessary check Ding Tianhong
2015-04-15 14:14 ` Arnd Bergmann
2015-04-15 12:30 ` [PATCH net-next 6/6] net: hip04: add ratelimit for rx/tx drops skb Ding Tianhong
[not found] ` <1429101008-9464-7-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 14:20 ` Arnd Bergmann
2015-04-15 14:25 ` [PATCH net-next 0/6] net: hip04: fix some problem for hip04 drivers Arnd Bergmann
2015-04-16 6:28 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429101008-9464-2-git-send-email-dingtianhong@huawei.com \
--to=dingtianhong@huawei.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=grant.likely@linaro.org \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).