From mboxrd@z Thu Jan 1 00:00:00 1970 From: chaotian.jing Subject: Re: [PATCH v2 2/5] mmc: mediatek: Add Mediatek MMC driver Date: Sun, 19 Apr 2015 11:22:41 +0800 Message-ID: <1429413761.16027.2.camel@mhfsdcap03> References: <1426562035-16709-1-git-send-email-chaotian.jing@mediatek.com> <1426562035-16709-3-git-send-email-chaotian.jing@mediatek.com> <20150417134547.GN4946@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150417134547.GN4946-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Sascha Hauer Cc: Mark Rutland , James Liao , Ulf Hansson , Arnd Bergmann , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hongzhou Yang , Catalin Marinas , bin.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chris Ball , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sascha Hauer , Matthias Brugger , "Joe.C" , Eddie Huang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Dear Sascha, On Fri, 2015-04-17 at 15:45 +0200, Sascha Hauer wrote: > Hi Chaotian, > > On Tue, Mar 17, 2015 at 11:13:52AM +0800, Chaotian Jing wrote: > > Add Mediatek MMC driver code > > > > [...] > > > + host->dev = &pdev->dev; > > + host->mmc = mmc; > > + /* Set host parameters to mmc */ > > + mmc->ops = &mt_msdc_ops; > > + mmc->f_min = 260000; > > + mmc->ocr_avail = MMC_VDD_30_31 | MMC_VDD_31_32 | MMC_VDD_32_33; > > + > > + mmc->caps |= MMC_CAP_ERASE | MMC_CAP_CMD23; > > + /* MMC core transfer sizes tunable parameters */ > > + mmc->max_segs = MAX_BD_NUM; > > + mmc->max_seg_size = 64 * 1024; > > Earlier versions of this driver had 64 * 1024 - 512 here. Using 64k > breaks SD card support here. Reading the partition table still works > fine, but the next transfers fail with messages like: > > mtk-msdc 11240000.mmc: msdc_request_timeout: aborting cmd/data/mrq > mtk-msdc 11240000.mmc: msdc_request_timeout: aborting mrq=ffffffc06e586860 cmd=18 > mtk-msdc 11240000.mmc: msdc_request_timeout: abort data: cmd18; 136 blocks > mmcblk1: error -110 transferring data, sector 338488, nr 136, cmd response 0x900, card status 0xb00 > mtk-msdc 11240000.mmc: set mclk to 0 mmc1: tried to reset card > > Can you confirm this? > Yes, it will be fixed at next revision. Thx! > Sascha >