From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Vivek Goyal <vgoyal@redhat.com>,
Jakub Sitnicki <jsitnicki@gmail.com>,
Mike Travis <travis@sgi.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Thierry Reding <treding@nvidia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH 2/2 v2] of/platform: Use platform_device interface
Date: Tue, 21 Apr 2015 10:25:02 +0200 [thread overview]
Message-ID: <1429604702-14157-2-git-send-email-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <1429604702-14157-1-git-send-email-ricardo.ribalda@gmail.com>
of_platform_device_create_pdata() was using of_device_add() to create
the devices, but of_platform_device_destroy was using
of_platform_device_destroy().
of_device_add(), do not call insert_resource(), which initializes the
parent field of the resource structure, needed by release_resource(),
called by of_platform_device_destroy().
This leads to a NULL pointer deference.
This patch, replaces of_device_add() with platform_device_data().
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/of/platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index a01f57c..f011f57 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -183,8 +183,9 @@ static struct platform_device *of_platform_device_create_pdata(
dev->dev.bus = &platform_bus_type;
dev->dev.platform_data = platform_data;
of_dma_configure(&dev->dev, dev->dev.of_node);
+ dev->name = dev_name(&dev->dev);
- if (of_device_add(dev) != 0) {
+ if (platform_device_add(dev) != 0) {
of_dma_deconfigure(&dev->dev);
platform_device_put(dev);
goto err_clear_flag;
--
2.1.4
next prev parent reply other threads:[~2015-04-21 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 8:25 [PATCH 1/2 v2] kernel/resource: Invalid memory access in __release_resource Ricardo Ribalda Delgado
2015-04-21 8:25 ` Ricardo Ribalda Delgado [this message]
[not found] ` <1429604702-14157-2-git-send-email-ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-21 20:13 ` [PATCH 2/2 v2] of/platform: Use platform_device interface Rob Herring
2015-04-21 21:09 ` Ricardo Ribalda Delgado
2015-04-21 23:01 ` Rob Herring
2015-06-04 5:25 ` Grant Likely
[not found] ` <20150604052536.DA31EC40548-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2015-06-04 8:48 ` Ricardo Ribalda Delgado
[not found] ` <CAPybu_0xjwExa4=6soyF=Uad6yxiFaCnO32FY5h7YLfg-SMovg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-05 10:52 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429604702-14157-2-git-send-email-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jiang.liu@linux.intel.com \
--cc=jsitnicki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=travis@sgi.com \
--cc=treding@nvidia.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).