From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jakub Sitnicki <jsitnicki@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Mike Travis <travis@sgi.com>, Thierry Reding <treding@nvidia.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH v4 0/4] Fix null pointer deference when calling of_platform_depopulate
Date: Thu, 23 Apr 2015 15:58:10 +0200 [thread overview]
Message-ID: <1429797494-29242-1-git-send-email-ricardo.ribalda@gmail.com> (raw)
of_platform_depopulate can lead to a kernel error when calling release_resource()
The reason is that it is trying to release a resource that was not allocated
via insert_resource()
of_platform_depopulate()
of_platform_device_destroy()
platform_device_unregister(platform_device *pdev)
platform_device_del(platform_device *pdev)
for (i = 0; i < pdev->num_resources; i++)
release_resource()
of_platform_populate()
...
of_device_alloc()
pdev = platform_device_alloc()
# set pdev->resource, similar to platform_device_add_resources()
of_device_add(platform_device *pdev)
# similar to platform_device_add(), but note there's no
# insert_resource() in this path
device_add(&pdev->dev)
On this patchset:
base/platform has been fixed for an hypothetical condition where parent is
set but the platform is neither MEM or IO.
Then platform_device_alloc has been modified so it supports of and amba
devices.
Finally of_device_add has been modified to use platform_device_add().
v1: https://lkml.org/lkml/2015/4/20/435
v2: From: Bjorn Helgaas <bhelgaas@google.com>
-Fix caller, not callee
https://lkml.org/lkml/2015/4/21/99
https://lkml.org/lkml/2015/4/21/100
v3: From: Rob Herring <robherring2@gmail.com>
- Modify plaform_device_alloc to support of and ambda devices
https://lkml.org/lkml/2015/4/22/369
https://lkml.org/lkml/2015/4/22/370
https://lkml.org/lkml/2015/4/22/371
https://lkml.org/lkml/2015/4/22/374
https://lkml.org/lkml/2015/4/22/373
v4: From: Bjorn Helgaas <bhelgaas@google.com>
-Remove WARN() patch
-Show conflicting resources
-Code Style
-Fix descriptions
From: Rob Herring <robherring2@gmail.com>
-Fix descriptions
Ricardo Ribalda Delgado (4):
base/platform: Only insert MEM and IO resources
base/platform: Continue on insert_resource() error
of/platform: Use platform_device interface
base/platform: Remove code duplication
drivers/base/platform.c | 84 ++++++++++++++++++++++++-------------------------
drivers/of/platform.c | 3 +-
2 files changed, 43 insertions(+), 44 deletions(-)
--
2.1.4
next reply other threads:[~2015-04-23 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 13:58 Ricardo Ribalda Delgado [this message]
[not found] ` <1429797494-29242-1-git-send-email-ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-23 13:58 ` [PATCH v4 1/4] base/platform: Only insert MEM and IO resources Ricardo Ribalda Delgado
[not found] ` <1429797494-29242-2-git-send-email-ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-13 13:56 ` Rob Herring
[not found] ` <CAL_JsqK8UAQwns7Bb3MQDXKBcqwBfQdswrnnOwUKKJROse7LXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-13 14:01 ` Ricardo Ribalda Delgado
2015-06-07 14:26 ` Grant Likely
2015-04-23 13:58 ` [PATCH v4 2/4] base/platform: Continue on insert_resource() error Ricardo Ribalda Delgado
[not found] ` <1429797494-29242-3-git-send-email-ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-13 14:11 ` Rob Herring
2015-04-23 13:58 ` [PATCH v4 3/4] of/platform: Use platform_device interface Ricardo Ribalda Delgado
2015-05-13 14:08 ` Rob Herring
2015-04-23 13:58 ` [PATCH v4 4/4] base/platform: Remove code duplication Ricardo Ribalda Delgado
2015-05-13 14:03 ` Rob Herring
[not found] ` <CAL_JsqLOBvTgaLx7Ev3y5UQQdKGqMwnYSptDKvBQmmN0EnQL5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-07 14:32 ` Grant Likely
2015-05-13 12:31 ` [PATCH v4 0/4] Fix null pointer deference when calling of_platform_depopulate Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429797494-29242-1-git-send-email-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=jsitnicki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=travis@sgi.com \
--cc=treding@nvidia.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).