From: Paul Bolle <pebolle@tiscali.nl>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org, Liviu Dudau <Liviu.Dudau@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Jon Medhurst (Tixy)" <tixy@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol
Date: Tue, 28 Apr 2015 09:36:04 +0200 [thread overview]
Message-ID: <1430206564.2411.21.camel@x220> (raw)
In-Reply-To: <1430134846-24320-2-git-send-email-sudeep.holla@arm.com>
Just one nit: a license mismatch.
On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote:
> --- /dev/null
> +++ b/drivers/mailbox/scpi_protocol.c
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program. If not, see <http://www.gnu.org/licenses/>.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think either the comment at the top of this file or
the license ident used in the MODULE_LICENSE() macro should be changed.
Likewise for 2/4 and 4/4.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-04-28 7:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430134846-24320-1-git-send-email-sudeep.holla@arm.com>
[not found] ` <1430134846-24320-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2015-04-27 11:40 ` [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol Sudeep Holla
2015-04-28 7:36 ` Paul Bolle [this message]
2015-04-28 8:41 ` Sudeep Holla
2015-04-28 13:54 ` Jon Medhurst (Tixy)
2015-04-29 10:53 ` Sudeep Holla
2015-04-29 11:43 ` Jon Medhurst (Tixy)
2015-04-29 12:25 ` Jon Medhurst (Tixy)
2015-04-29 13:08 ` Sudeep Holla
2015-04-30 8:49 ` Jon Medhurst (Tixy)
2015-04-29 13:01 ` Sudeep Holla
2015-05-13 16:52 ` Jassi Brar
2015-05-13 17:09 ` Sudeep Holla
[not found] ` <55538540.1010505-5wv7dgnIgG8@public.gmane.org>
2015-05-14 7:02 ` Jassi Brar
2015-05-14 7:30 ` Jassi Brar
[not found] ` <CABb+yY0J1j=wMaKj+1nohU7qJpVS83BD_AX3Mf56T5+6V6+NOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-14 8:25 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430206564.2411.21.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=Liviu.Dudau@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).