* [PATCH v3 0/3] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller.
@ 2015-05-01 4:54 Suman Tripathi
2015-05-01 4:54 ` [PATCH v3 1/3] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Suman Tripathi @ 2015-05-01 4:54 UTC (permalink / raw)
To: chris, anton, arnd, michal.simek
Cc: linux-mmc, linuxppc-dev, devicetree, linux-arm-kernel, ddutile,
jcm, mlangsdo, patches, Suman Tripathi
This patch adds the SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller.
v1 change:
* Use the CONFIG_ARM64_DMA_HAS_IOMMU for dma-mapping.
v2 change:
* Drop the IOMMU support and switching to PIO mode for arasan.
controller integrated inside APM X-Gene SoC.
v3 change:
* Change the sdhci-of-arasan.c to support arasan4.9a.
* Add quirks for arasan4.9a.
Signed-off-by: Suman Tripathi <stripathi@apm.com>
---
Suman Tripathi (3):
arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.
mmc: host: arasan: Add the support for sdhci-arasan4.9a in
sdhci-of-arasan.c
Documentation: mmc: Update Arasan SDHC documentation to support 4.9a
version of Arasan SDHC controller.
.../devicetree/bindings/mmc/arasan,sdhci.txt | 5 ++-
arch/arm64/boot/dts/apm-mustang.dts | 4 ++
arch/arm64/boot/dts/apm-storm.dtsi | 44 ++++++++++++++++++++++
drivers/mmc/host/sdhci-of-arasan.c | 7 ++++
4 files changed, 58 insertions(+), 2 deletions(-)
--
1.8.2.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v3 1/3] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. 2015-05-01 4:54 [PATCH v3 0/3] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi @ 2015-05-01 4:54 ` Suman Tripathi 2015-05-04 6:03 ` Michal Simek [not found] ` <1430456052-8888-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org> 2015-05-01 4:54 ` [PATCH v3 3/3] Documentation: mmc: Update Arasan SDHC documentation to support 4.9a version of Arasan SDHC controller Suman Tripathi 2 siblings, 1 reply; 9+ messages in thread From: Suman Tripathi @ 2015-05-01 4:54 UTC (permalink / raw) To: chris, anton, arnd, michal.simek Cc: linux-mmc, linuxppc-dev, devicetree, linux-arm-kernel, ddutile, jcm, mlangsdo, patches, Suman Tripathi This patch adds the arasan sdhc nodes to reuse the of-arasan driver for APM X-Gene SoC. Signed-off-by: Suman Tripathi <stripathi@apm.com> --- arch/arm64/boot/dts/apm-mustang.dts | 4 ++++ arch/arm64/boot/dts/apm-storm.dtsi | 44 +++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) diff --git a/arch/arm64/boot/dts/apm-mustang.dts b/arch/arm64/boot/dts/apm-mustang.dts index 8eb6d94..d0e52a9 100644 --- a/arch/arm64/boot/dts/apm-mustang.dts +++ b/arch/arm64/boot/dts/apm-mustang.dts @@ -44,3 +44,7 @@ &xgenet { status = "ok"; }; + +&sdhc0 { + status = "ok"; +}; diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi index 87d3205..d6c2216 100644 --- a/arch/arm64/boot/dts/apm-storm.dtsi +++ b/arch/arm64/boot/dts/apm-storm.dtsi @@ -144,6 +144,40 @@ clock-output-names = "socplldiv2"; }; + ahbclk: ahbclk@1f2ac000 { + compatible = "apm,xgene-device-clock"; + #clock-cells = <1>; + clocks = <&socplldiv2 0>; + reg = <0x0 0x1f2ac000 0x0 0x1000 + 0x0 0x17000000 0x0 0x2000>; + reg-names = "csr-reg", "div-reg"; + csr-offset = <0x0>; + csr-mask = <0x1>; + enable-offset = <0x8>; + enable-mask = <0x1>; + divider-offset = <0x164>; + divider-width = <0x5>; + divider-shift = <0x0>; + clock-output-names = "ahbclk"; + }; + + sdioclk: sdioclk@1f2ac000 { + compatible = "apm,xgene-device-clock"; + #clock-cells = <1>; + clocks = <&socplldiv2 0>; + reg = <0x0 0x1f2ac000 0x0 0x1000 + 0x0 0x17000000 0x0 0x2000>; + reg-names = "csr-reg", "div-reg"; + csr-offset = <0x0>; + csr-mask = <0x2>; + enable-offset = <0x8>; + enable-mask = <0x2>; + divider-offset = <0x178>; + divider-width = <0x8>; + divider-shift = <0x0>; + clock-output-names = "sdioclk"; + }; + qmlclk: qmlclk { compatible = "apm,xgene-device-clock"; #clock-cells = <1>; @@ -503,6 +537,16 @@ interrupts = <0x0 0x4f 0x4>; }; + sdhc0: sdhc@1c000000 { + device_type = "sdhc"; + compatible = "arasan,sdhci-8.9a", "arasan,sdhci-4.9a"; + reg = <0x0 0x1c000000 0x0 0x100>; + interrupts = <0x0 0x49 0x4>; + dma-coherent; + clock-names = "clk_xin", "clk_ahb"; + clocks = <&sdioclk 0>, <&ahbclk 0>; + }; + phy1: phy@1f21a000 { compatible = "apm,xgene-phy"; reg = <0x0 0x1f21a000 0x0 0x100>; -- 1.8.2.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/3] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. 2015-05-01 4:54 ` [PATCH v3 1/3] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi @ 2015-05-04 6:03 ` Michal Simek 2015-05-04 6:14 ` Suman Tripathi 0 siblings, 1 reply; 9+ messages in thread From: Michal Simek @ 2015-05-04 6:03 UTC (permalink / raw) To: Suman Tripathi, chris, anton, arnd, michal.simek Cc: devicetree, mlangsdo, jcm, linux-mmc, patches, ddutile, linuxppc-dev, linux-arm-kernel On 05/01/2015 06:54 AM, Suman Tripathi wrote: > This patch adds the arasan sdhc nodes to reuse the of-arasan > driver for APM X-Gene SoC. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > arch/arm64/boot/dts/apm-mustang.dts | 4 ++++ > arch/arm64/boot/dts/apm-storm.dtsi | 44 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 48 insertions(+) > > diff --git a/arch/arm64/boot/dts/apm-mustang.dts b/arch/arm64/boot/dts/apm-mustang.dts > index 8eb6d94..d0e52a9 100644 > --- a/arch/arm64/boot/dts/apm-mustang.dts > +++ b/arch/arm64/boot/dts/apm-mustang.dts > @@ -44,3 +44,7 @@ > &xgenet { > status = "ok"; > }; > + > +&sdhc0 { > + status = "ok"; > +}; > diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi > index 87d3205..d6c2216 100644 > --- a/arch/arm64/boot/dts/apm-storm.dtsi > +++ b/arch/arm64/boot/dts/apm-storm.dtsi > @@ -144,6 +144,40 @@ > clock-output-names = "socplldiv2"; > }; > > + ahbclk: ahbclk@1f2ac000 { > + compatible = "apm,xgene-device-clock"; > + #clock-cells = <1>; > + clocks = <&socplldiv2 0>; > + reg = <0x0 0x1f2ac000 0x0 0x1000 > + 0x0 0x17000000 0x0 0x2000>; > + reg-names = "csr-reg", "div-reg"; > + csr-offset = <0x0>; > + csr-mask = <0x1>; > + enable-offset = <0x8>; > + enable-mask = <0x1>; > + divider-offset = <0x164>; > + divider-width = <0x5>; > + divider-shift = <0x0>; > + clock-output-names = "ahbclk"; > + }; > + > + sdioclk: sdioclk@1f2ac000 { > + compatible = "apm,xgene-device-clock"; > + #clock-cells = <1>; > + clocks = <&socplldiv2 0>; > + reg = <0x0 0x1f2ac000 0x0 0x1000 > + 0x0 0x17000000 0x0 0x2000>; > + reg-names = "csr-reg", "div-reg"; > + csr-offset = <0x0>; > + csr-mask = <0x2>; > + enable-offset = <0x8>; > + enable-mask = <0x2>; > + divider-offset = <0x178>; > + divider-width = <0x8>; > + divider-shift = <0x0>; > + clock-output-names = "sdioclk"; > + }; > + > qmlclk: qmlclk { > compatible = "apm,xgene-device-clock"; > #clock-cells = <1>; > @@ -503,6 +537,16 @@ > interrupts = <0x0 0x4f 0x4>; > }; > > + sdhc0: sdhc@1c000000 { > + device_type = "sdhc"; > + compatible = "arasan,sdhci-8.9a", "arasan,sdhci-4.9a"; I would just add 4.9a here because you want to use that quirks. We can add some quirks to 8.9a version if any new problem arises. Thanks, Michal ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 1/3] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. 2015-05-04 6:03 ` Michal Simek @ 2015-05-04 6:14 ` Suman Tripathi 0 siblings, 0 replies; 9+ messages in thread From: Suman Tripathi @ 2015-05-04 6:14 UTC (permalink / raw) To: Michal Simek Cc: Chris Ball, Anton Vorontsov, Arnd Bergmann, linux-mmc, linuxppc-dev, devicetree@vger.kernel.org, linux-arm-kernel, Don Dutile, Jon Masters, Mark Langsdorf, patches Hi, On Mon, May 4, 2015 at 11:33 AM, Michal Simek <michal.simek@xilinx.com> wrote: > On 05/01/2015 06:54 AM, Suman Tripathi wrote: >> This patch adds the arasan sdhc nodes to reuse the of-arasan >> driver for APM X-Gene SoC. >> >> Signed-off-by: Suman Tripathi <stripathi@apm.com> >> --- >> arch/arm64/boot/dts/apm-mustang.dts | 4 ++++ >> arch/arm64/boot/dts/apm-storm.dtsi | 44 +++++++++++++++++++++++++++++++++++++ >> 2 files changed, 48 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/apm-mustang.dts b/arch/arm64/boot/dts/apm-mustang.dts >> index 8eb6d94..d0e52a9 100644 >> --- a/arch/arm64/boot/dts/apm-mustang.dts >> +++ b/arch/arm64/boot/dts/apm-mustang.dts >> @@ -44,3 +44,7 @@ >> &xgenet { >> status = "ok"; >> }; >> + >> +&sdhc0 { >> + status = "ok"; >> +}; >> diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi >> index 87d3205..d6c2216 100644 >> --- a/arch/arm64/boot/dts/apm-storm.dtsi >> +++ b/arch/arm64/boot/dts/apm-storm.dtsi >> @@ -144,6 +144,40 @@ >> clock-output-names = "socplldiv2"; >> }; >> >> + ahbclk: ahbclk@1f2ac000 { >> + compatible = "apm,xgene-device-clock"; >> + #clock-cells = <1>; >> + clocks = <&socplldiv2 0>; >> + reg = <0x0 0x1f2ac000 0x0 0x1000 >> + 0x0 0x17000000 0x0 0x2000>; >> + reg-names = "csr-reg", "div-reg"; >> + csr-offset = <0x0>; >> + csr-mask = <0x1>; >> + enable-offset = <0x8>; >> + enable-mask = <0x1>; >> + divider-offset = <0x164>; >> + divider-width = <0x5>; >> + divider-shift = <0x0>; >> + clock-output-names = "ahbclk"; >> + }; >> + >> + sdioclk: sdioclk@1f2ac000 { >> + compatible = "apm,xgene-device-clock"; >> + #clock-cells = <1>; >> + clocks = <&socplldiv2 0>; >> + reg = <0x0 0x1f2ac000 0x0 0x1000 >> + 0x0 0x17000000 0x0 0x2000>; >> + reg-names = "csr-reg", "div-reg"; >> + csr-offset = <0x0>; >> + csr-mask = <0x2>; >> + enable-offset = <0x8>; >> + enable-mask = <0x2>; >> + divider-offset = <0x178>; >> + divider-width = <0x8>; >> + divider-shift = <0x0>; >> + clock-output-names = "sdioclk"; >> + }; >> + >> qmlclk: qmlclk { >> compatible = "apm,xgene-device-clock"; >> #clock-cells = <1>; >> @@ -503,6 +537,16 @@ >> interrupts = <0x0 0x4f 0x4>; >> }; >> >> + sdhc0: sdhc@1c000000 { >> + device_type = "sdhc"; >> + compatible = "arasan,sdhci-8.9a", "arasan,sdhci-4.9a"; > > I would just add 4.9a here because you want to use that quirks. We can > add some quirks to 8.9a version if any new problem arises. Make sense too. Our's is 4.9a. Thanks for the catch. > > Thanks, > Michal -- Thanks, with regards, Suman Tripathi ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <1430456052-8888-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>]
* [PATCH v3 2/3] mmc: host: arasan: Add the support for sdhci-arasan4.9a in sdhci-of-arasan.c. [not found] ` <1430456052-8888-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org> @ 2015-05-01 4:54 ` Suman Tripathi 0 siblings, 0 replies; 9+ messages in thread From: Suman Tripathi @ 2015-05-01 4:54 UTC (permalink / raw) To: chris-OsFVWbfNK3isTnJN9+BGXg, anton-9xeibp6oKSgdnm+yROfE0A, arnd-r2nGTMty4D4, michal.simek-gjFFaj9aHVfQT0dZR+AlfA Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, ddutile-H+wXaHxf7aLQT0dZR+AlfA, jcm-H+wXaHxf7aLQT0dZR+AlfA, mlangsdo-H+wXaHxf7aLQT0dZR+AlfA, patches-qTEPVZfXA3Y, Suman Tripathi This patch adds the quirks and compatible string in sdhci-of-arasan.c to support sdhci-arasan4.9a version of controller. Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> --- drivers/mmc/host/sdhci-of-arasan.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 981d66e..92a4222 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -20,6 +20,7 @@ */ #include <linux/module.h> +#include <linux/of_device.h> #include "sdhci-pltfm.h" #define SDHCI_ARASAN_CLK_CTRL_OFFSET 0x2c @@ -169,6 +170,11 @@ static int sdhci_arasan_probe(struct platform_device *pdev) goto clk_disable_all; } + if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) { + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; + } + sdhci_get_of_property(pdev); pltfm_host = sdhci_priv(host); pltfm_host->priv = sdhci_arasan; @@ -206,6 +212,7 @@ static int sdhci_arasan_remove(struct platform_device *pdev) static const struct of_device_id sdhci_arasan_of_match[] = { { .compatible = "arasan,sdhci-8.9a" }, + { .compatible = "arasan,sdhci-4.9a" }, { } }; MODULE_DEVICE_TABLE(of, sdhci_arasan_of_match); -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 3/3] Documentation: mmc: Update Arasan SDHC documentation to support 4.9a version of Arasan SDHC controller. 2015-05-01 4:54 [PATCH v3 0/3] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi 2015-05-01 4:54 ` [PATCH v3 1/3] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi [not found] ` <1430456052-8888-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org> @ 2015-05-01 4:54 ` Suman Tripathi [not found] ` <1430456052-8888-4-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org> 2 siblings, 1 reply; 9+ messages in thread From: Suman Tripathi @ 2015-05-01 4:54 UTC (permalink / raw) To: chris, anton, arnd, michal.simek Cc: linux-mmc, linuxppc-dev, devicetree, linux-arm-kernel, ddutile, jcm, mlangsdo, patches, Suman Tripathi This patch updates Arasan SDHC documentation to support 4.9a version of Arasan SDHC controller. Signed-off-by: Suman Tripathi <stripathi@apm.com> --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index 98ee2ab..f01d41a 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -8,7 +8,8 @@ Device Tree Bindings for the Arasan SDHCI Controller [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Required Properties: - - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' + - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or + 'arasan,sdhci-4.9a' - reg: From mmc bindings: Register location and length. - clocks: From clock bindings: Handles to clock inputs. - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb" @@ -18,7 +19,7 @@ Required Properties: Example: sdhci@e0100000 { - compatible = "arasan,sdhci-8.9a"; + compatible = "arasan,sdhci-8.9a", "arasan,sdhci-4.9a"; reg = <0xe0100000 0x1000>; clock-names = "clk_xin", "clk_ahb"; clocks = <&clkc 21>, <&clkc 32>; -- 1.8.2.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <1430456052-8888-4-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>]
* Re: [PATCH v3 3/3] Documentation: mmc: Update Arasan SDHC documentation to support 4.9a version of Arasan SDHC controller. [not found] ` <1430456052-8888-4-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org> @ 2015-05-04 6:00 ` Michal Simek 2015-05-04 6:03 ` Suman Tripathi 0 siblings, 1 reply; 9+ messages in thread From: Michal Simek @ 2015-05-04 6:00 UTC (permalink / raw) To: Suman Tripathi, chris-OsFVWbfNK3isTnJN9+BGXg, anton-9xeibp6oKSgdnm+yROfE0A, arnd-r2nGTMty4D4, michal.simek-gjFFaj9aHVfQT0dZR+AlfA Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, ddutile-H+wXaHxf7aLQT0dZR+AlfA, jcm-H+wXaHxf7aLQT0dZR+AlfA, mlangsdo-H+wXaHxf7aLQT0dZR+AlfA, patches-qTEPVZfXA3Y On 05/01/2015 06:54 AM, Suman Tripathi wrote: > This patch updates Arasan SDHC documentation to support > 4.9a version of Arasan SDHC controller. > > Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 98ee2ab..f01d41a 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -8,7 +8,8 @@ Device Tree Bindings for the Arasan SDHCI Controller > [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > Required Properties: > - - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' > + - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or > + 'arasan,sdhci-4.9a' > - reg: From mmc bindings: Register location and length. > - clocks: From clock bindings: Handles to clock inputs. > - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb" > @@ -18,7 +19,7 @@ Required Properties: > > Example: > sdhci@e0100000 { > - compatible = "arasan,sdhci-8.9a"; > + compatible = "arasan,sdhci-8.9a", "arasan,sdhci-4.9a"; Is there any reason to change this example? You probably want to have just one compatible string not both. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] Documentation: mmc: Update Arasan SDHC documentation to support 4.9a version of Arasan SDHC controller. 2015-05-04 6:00 ` Michal Simek @ 2015-05-04 6:03 ` Suman Tripathi [not found] ` <CAOHikRBbOYHOmnzA6Ycu6hwdNL6SgmXKVK0NLtJQfJL9KULuxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Suman Tripathi @ 2015-05-04 6:03 UTC (permalink / raw) To: Michal Simek Cc: Chris Ball, Anton Vorontsov, Arnd Bergmann, linux-mmc, linuxppc-dev, devicetree@vger.kernel.org, linux-arm-kernel, Don Dutile, Jon Masters, Mark Langsdorf, patches Hi, On Mon, May 4, 2015 at 11:30 AM, Michal Simek <michal.simek@xilinx.com> wrote: > On 05/01/2015 06:54 AM, Suman Tripathi wrote: >> This patch updates Arasan SDHC documentation to support >> 4.9a version of Arasan SDHC controller. >> >> Signed-off-by: Suman Tripathi <stripathi@apm.com> >> --- >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> index 98ee2ab..f01d41a 100644 >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> @@ -8,7 +8,8 @@ Device Tree Bindings for the Arasan SDHCI Controller >> [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >> >> Required Properties: >> - - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' >> + - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or >> + 'arasan,sdhci-4.9a' >> - reg: From mmc bindings: Register location and length. >> - clocks: From clock bindings: Handles to clock inputs. >> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb" >> @@ -18,7 +19,7 @@ Required Properties: >> >> Example: >> sdhci@e0100000 { >> - compatible = "arasan,sdhci-8.9a"; >> + compatible = "arasan,sdhci-8.9a", "arasan,sdhci-4.9a"; > > Is there any reason to change this example? Thought that if dts is updated so why not update the binding too. > You probably want to have just one compatible string not both. Okay will remove in next version. > > Thanks, > Michal > > > > -- Thanks, with regards, Suman Tripathi ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <CAOHikRBbOYHOmnzA6Ycu6hwdNL6SgmXKVK0NLtJQfJL9KULuxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH v3 3/3] Documentation: mmc: Update Arasan SDHC documentation to support 4.9a version of Arasan SDHC controller. [not found] ` <CAOHikRBbOYHOmnzA6Ycu6hwdNL6SgmXKVK0NLtJQfJL9KULuxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-05-04 6:29 ` Michal Simek 0 siblings, 0 replies; 9+ messages in thread From: Michal Simek @ 2015-05-04 6:29 UTC (permalink / raw) To: Suman Tripathi, Michal Simek Cc: Chris Ball, Anton Vorontsov, Arnd Bergmann, linux-mmc, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel, Don Dutile, Jon Masters, Mark Langsdorf, patches On 05/04/2015 08:03 AM, Suman Tripathi wrote: > Hi, > > On Mon, May 4, 2015 at 11:30 AM, Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> wrote: >> On 05/01/2015 06:54 AM, Suman Tripathi wrote: >>> This patch updates Arasan SDHC documentation to support >>> 4.9a version of Arasan SDHC controller. >>> >>> Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> >>> --- >>> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >>> index 98ee2ab..f01d41a 100644 >>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >>> @@ -8,7 +8,8 @@ Device Tree Bindings for the Arasan SDHCI Controller >>> [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >>> >>> Required Properties: >>> - - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' >>> + - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or >>> + 'arasan,sdhci-4.9a' >>> - reg: From mmc bindings: Register location and length. >>> - clocks: From clock bindings: Handles to clock inputs. >>> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb" >>> @@ -18,7 +19,7 @@ Required Properties: >>> >>> Example: >>> sdhci@e0100000 { >>> - compatible = "arasan,sdhci-8.9a"; >>> + compatible = "arasan,sdhci-8.9a", "arasan,sdhci-4.9a"; >> >> Is there any reason to change this example? > > Thought that if dts is updated so why not update the binding too. It is just about updating example. It is fine to update binding. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-05-04 6:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-01 4:54 [PATCH v3 0/3] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi
2015-05-01 4:54 ` [PATCH v3 1/3] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi
2015-05-04 6:03 ` Michal Simek
2015-05-04 6:14 ` Suman Tripathi
[not found] ` <1430456052-8888-1-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2015-05-01 4:54 ` [PATCH v3 2/3] mmc: host: arasan: Add the support for sdhci-arasan4.9a in sdhci-of-arasan.c Suman Tripathi
2015-05-01 4:54 ` [PATCH v3 3/3] Documentation: mmc: Update Arasan SDHC documentation to support 4.9a version of Arasan SDHC controller Suman Tripathi
[not found] ` <1430456052-8888-4-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2015-05-04 6:00 ` Michal Simek
2015-05-04 6:03 ` Suman Tripathi
[not found] ` <CAOHikRBbOYHOmnzA6Ycu6hwdNL6SgmXKVK0NLtJQfJL9KULuxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-04 6:29 ` Michal Simek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).