From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Kumar Gala <galak@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components
Date: Fri, 08 May 2015 17:17:20 +0300 [thread overview]
Message-ID: <1431094640.21307.23.camel@linaro.org> (raw)
In-Reply-To: <CANLsYkyNYQf80c+8uMbZDr=kQ2YEOqy2aS8muEJsLsanDRGLOQ@mail.gmail.com>
On Fri, 2015-05-08 at 08:13 -0600, Mathieu Poirier wrote:
> On 8 May 2015 at 07:47, Ivan T. Ivanov ivanov@linaro.org> wrote:
> > On Fri, 2015-05-08 at 07:38 -0600, Mathieu Poirier wrote:
> > > On 7 May 2015 at 09:36, Ivan T. Ivanov ivanov@linaro.org> wrote:
> > > > Add initial set of CoreSight components found on Qualcomm's 8x16 chipset.
> > > >
> > > >
> > > > + replicator@824000 {
> > > > + compatible = "qcom,coresight-replicator", "arm,primecell";
> > >
> > > Shouldn't it be "qcom,coresight-replicator1x" ?
> > >
> >
> >
> >
> > True, I still wonder, why we have to have this compatible string?
> > Drivers are probed by amba_id and "arm,primecell", after all.
> >
>
> Drivers have their own compatible strings for historical reasons,
> something I've been meaning to fix for a long time now...
>
Yep, I see that they have been platform drivers in the past, but now
they are not, except coresight-replicator driver. IMHO, having
additional compatible string could lead just to confusion.
Regards,
Ivan
next prev parent reply other threads:[~2015-05-08 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 15:36 [PATCH v2 0/2] Add initial CoreSight support for the Qualcomm 8x16 chipsets Ivan T. Ivanov
2015-05-07 15:36 ` [PATCH v2 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver Ivan T. Ivanov
2015-05-11 19:07 ` Mathieu Poirier
2015-05-18 12:51 ` Ivan T. Ivanov
2015-05-07 15:36 ` [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components Ivan T. Ivanov
2015-05-08 13:38 ` Mathieu Poirier
2015-05-08 13:47 ` Ivan T. Ivanov
2015-05-08 14:13 ` Mathieu Poirier
2015-05-08 14:17 ` Ivan T. Ivanov [this message]
[not found] ` <1431094640.21307.23.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-08 16:17 ` Mathieu Poirier
[not found] ` <CANLsYkxFzQPCWXb0w8BddtuJB_cXUtUHBTapYFDF9zqhDBQHrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-08 17:57 ` Ivan T. Ivanov
2015-05-08 18:01 ` Mathieu Poirier
2015-05-08 18:00 ` Mark Rutland
2015-05-08 18:17 ` Ivan T. Ivanov
2015-05-11 11:04 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431094640.21307.23.camel@linaro.org \
--to=ivan.ivanov@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=pawel.moll@arm.com \
--cc=pratikp@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).