From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components Date: Fri, 08 May 2015 17:17:20 +0300 Message-ID: <1431094640.21307.23.camel@linaro.org> References: <1431012969-16338-1-git-send-email-ivan.ivanov@linaro.org> <1431012969-16338-3-git-send-email-ivan.ivanov@linaro.org> <1431092877.21307.18.camel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org To: Mathieu Poirier Cc: Kumar Gala , Pratik Patel , Catalin Marinas , Will Deacon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-arm-msm@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, 2015-05-08 at 08:13 -0600, Mathieu Poirier wrote: > On 8 May 2015 at 07:47, Ivan T. Ivanov ivanov@linaro.org> wrote: > > On Fri, 2015-05-08 at 07:38 -0600, Mathieu Poirier wrote: > > > On 7 May 2015 at 09:36, Ivan T. Ivanov ivanov@linaro.org> wrote: > > > > Add initial set of CoreSight components found on Qualcomm's 8x1= 6 chipset. > > > >=20 > > > >=20 > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0replicator@824000 { > > > > + compatible =3D "qcom,coresight-replicator", "ar= m,primecell"; > > >=20 > > > Shouldn't it be "qcom,coresight-replicator1x" ? > > >=20 > >=20 > >=20 > >=20 > > True, I still wonder, why we have to have this compatible string? > > Drivers are probed by amba_id and "arm,primecell", after all. > >=20 >=20 > Drivers have their own compatible strings for historical reasons, > something I've been meaning to fix for a long time now... >=20 Yep, I see that they have been platform drivers in the past, but now=20 they are not, except coresight-replicator driver. IMHO, having additional compatible string could lead just to confusion.=20 Regards, Ivan