From: Robert Nelson <robertcnelson@gmail.com>
To: tony@atomide.com, devicetree@vger.kernel.org
Cc: matthijsvanduin@gmail.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Robert Nelson <robertcnelson@gmail.com>,
Felipe Balbi <balbi@ti.com>, Johan Hovold <johan@kernel.org>
Subject: [PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller
Date: Wed, 13 May 2015 08:50:01 -0500 [thread overview]
Message-ID: <1431525001-5747-1-git-send-email-robertcnelson@gmail.com> (raw)
Fixes: http://bugs.elinux.org/issues/143
Commit 672e2b147 which introduced proper shutdown chose to let the PMIC go into sleep-state (aka "RTC-only mode") rather than off-state. This was fine for rev A5 on which that patch was tested, but since then two changes have been made to the power supply scheme:
(rev A6) enable of the 3v3b regulator moved from LDO2 to LDO4 (3v3a)
side-effect: 3v3b rail remains on in sleep-mode (also in off-mode when battery-powered)
(rev A6A) am335x vdds supply moved from LDO3 to LDO1
side-effect: vdds remains supplied in sleep-mode
As a result heavy leakage occurs from vdds (directly) and 3v3b (via i/o pins) to the 3v3a. The amount of current depends on external connections, but for example leaving a serial console cable connected in this state resulted in serious violation of am335x absolute maximum ratings, with potential for hardware damage.
Reported-by: Matthijs van Duin <matthijsvanduin@gmail.com>
Tested-by: Matthijs van Duin <matthijsvanduin@gmail.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Johan Hovold <johan@kernel.org>
---
arch/arm/boot/dts/am335x-bone-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index c3255e0..7198b81 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -223,6 +223,8 @@
/include/ "tps65217.dtsi"
&tps {
+ ti,pmic-shutdown-controller;
+
regulators {
dcdc1_reg: regulator@0 {
regulator-name = "vdds_dpr";
--
2.1.4
next reply other threads:[~2015-05-13 13:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 13:50 Robert Nelson [this message]
2015-05-13 14:16 ` [PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller Johan Hovold
2015-05-13 14:48 ` Johan Hovold
2015-05-16 2:48 ` Matthijs van Duin
2015-05-18 15:21 ` Tony Lindgren
2015-05-18 16:13 ` Robert Nelson
[not found] ` <CAOCHtYgwyQy+hQE2PeUd+7U9wNygVOUuAb-VSh_9K5y7zFHEWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-18 16:29 ` Tony Lindgren
2015-05-18 16:49 ` Robert Nelson
[not found] ` <CAOCHtYjtziBwfSMGPRrQ7rfDEf_dC=7rPytQUxVXy8bSp-8NNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-18 17:03 ` Tony Lindgren
2015-05-18 18:01 ` Pantelis Antoniou
2015-05-18 18:14 ` Tony Lindgren
2015-05-18 18:18 ` Pantelis Antoniou
2015-05-18 20:37 ` Tony Lindgren
[not found] ` <20150518152108.GE10274-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-05-19 7:25 ` Matthijs van Duin
[not found] ` <CAALWOA-OwUuAbc7Wd_SV-14mVbOCVWvKwKgb3eOjVGEery28og-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-19 14:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431525001-5747-1-git-send-email-robertcnelson@gmail.com \
--to=robertcnelson@gmail.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=matthijsvanduin@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).