devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jon Medhurst (Tixy)" <tixy@linaro.org>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] arm64: Juno: Split juno.dts into juno-base.dtsi and juno.dts.
Date: Thu, 14 May 2015 10:35:42 +0100	[thread overview]
Message-ID: <1431596142.2881.13.camel@linaro.org> (raw)
In-Reply-To: <1431537092-19597-3-git-send-email-Liviu.Dudau@arm.com>

On Wed, 2015-05-13 at 18:11 +0100, Liviu Dudau wrote:
> Prepare the device tree for adding more boards based on Juno r0.
> 
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> ---
>  arch/arm64/boot/dts/arm/juno-base.dtsi | 125 +++++++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/arm/juno.dts       | 122 +-------------------------------


What criteria were used to select the contents of juno-base.dtsi?
>From what I can see, the stuff left out of base is still the same for r0
and r1 (cpu, pmu, memory, psci!). And so juno-r1.dts could just be

-------------------------------------------------------------------------
#include "juno.dts"

/ {
	model = "ARM Juno development board (r1)";

};

&memtimer {
	status = "okay";
};
-------------------------------------------------------------------------

Yes, it's a bit hacky, but avoids duplication of source code.

I can only assume there are come non-public differences between r0 and
r1?

-- 
Tixy

  reply	other threads:[~2015-05-14  9:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 17:11 [PATCH 0/5] arm64: Juno DT updates and new DT for Juno R1 Liviu Dudau
2015-05-13 17:11 ` [PATCH 1/5] arm64: Juno: Fix the GIC node address label and the frequency of FAXI clock Liviu Dudau
2015-05-13 17:11 ` [PATCH 2/5] arm64: Juno: Split juno.dts into juno-base.dtsi and juno.dts Liviu Dudau
2015-05-14  9:35   ` Jon Medhurst (Tixy) [this message]
2015-05-14 10:30     ` Liviu Dudau
2015-05-14 11:04       ` Jon Medhurst (Tixy)
     [not found]         ` <1431601471.2881.36.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-14 13:11           ` Liviu Dudau
2015-05-14 13:50             ` Jon Medhurst (Tixy)
2015-05-14 13:44           ` Sudeep Holla
2015-05-13 17:11 ` [PATCH 3/5] arm64: Juno: Add memory mapped timer node Liviu Dudau
2015-05-13 17:11 ` [PATCH 4/5] arm64: Juno: Add GICv2m support in device tree Liviu Dudau
2015-05-13 17:11 ` [PATCH 5/5] arm64: Add DT support for Juno r1 board Liviu Dudau
2015-05-14 14:07   ` Jon Medhurst (Tixy)
2015-05-14 14:14     ` Liviu Dudau
     [not found]     ` <1431612451.2881.54.camel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-14 14:18       ` Mark Rutland
2015-05-14 15:14         ` Jon Medhurst (Tixy)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431596142.2881.13.camel@linaro.org \
    --to=tixy@linaro.org \
    --cc=Liviu.Dudau@arm.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).