From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support Date: Sat, 16 May 2015 17:32:25 +0200 Message-ID: <1431790345.2341.37.camel@x220> References: <1431707940-19372-1-git-send-email-jenskuske@gmail.com> <1431707940-19372-8-git-send-email-jenskuske@gmail.com> Reply-To: pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1431707940-19372-8-git-send-email-jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jens Kuske Cc: Maxime Ripard , Emilio =?ISO-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Rob Herring , Chen-Yu Tsai , Vishnu Patekar , Hans de Goede , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Just a nit: a license mismatch. (I didn't bring this up in v1. Perhaps I should have.) On Fri, 2015-05-15 at 18:38 +0200, Jens Kuske wrote: > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c > + * This file is licensed under the terms of the GNU General Public > + * License version 2. This program is licensed "as is" without any > + * warranty of any kind, whether express or implied. This states the license is GPL v2. > +MODULE_LICENSE("GPL"); According to include/linux/module.h this states the license is GPL v2 or later. So I think that either the comment at the top of this file or the ident used in the MODULE_LICENSE() macro needs to change. Paul Bolle