From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yingjoe Chen Subject: Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller Date: Wed, 20 May 2015 11:07:39 +0800 Message-ID: <1432091259.20394.7.camel@mtksdaap41> References: <1431967209-5261-1-git-send-email-eddie.huang@mediatek.com> <1431967209-5261-3-git-send-email-eddie.huang@mediatek.com> <20150518184300.GB28888@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Matthias Brugger Cc: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Mark Rutland , Xudong Chen , srv_heupstream , Pawel Moll , Wolfram Sang , Ian Campbell , Liguo Zhang , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Rob Herring , linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Sascha Hauer , Kumar Gala , Eddie Huang , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, 2015-05-19 at 16:48 +0200, Matthias Brugger wrote: > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-K=C3=B6nig : <...> > >> --- /dev/null > >> +++ b/drivers/i2c/busses/i2c-mt65xx.c > >> @@ -0,0 +1,675 @@ > >> +/* > >> + * Copyright (c) 2014 MediaTek Inc. > >> + * Author: Xudong.chen > > s/Xudong.chen/Xudong Chen/ > > > >> +#define I2C_DRV_NAME "mt-i2c" > > i2c-mt65xx ? >=20 > As this works for all SoCs so far, I would propose: i2c-mtk Hi, I'm pretty sure this driver won't work for MTK TV socs(mt53xx) and BDP mt8580, they are using different I2C IP. They are not working on upstream now, but I think using i2c-mt65xx make more sense here. Joe.C