Re: [PATCH 5/5] ARM64: MediaTek MT8173: Add SCPSYS device node

[James Liao <jamesjj.liao@mediatek.com>]

Hi Daniel,

On Thu, 2015-05-21 at 19:49 +0200, Sascha Hauer wrote:
> On Thu, May 21, 2015 at 10:32:40PM +0800, Daniel Kurtz wrote:
> > > +               scpsys: scpsys@10006000 {
> > > +                       compatible = "mediatek,mt8173-scpsys";
> > > +                       #power-domain-cells = <1>;
> > > +                       reg = <0 0x10006000 0 0x1000>;
> > > +                       clocks = <&clk26m>,
> > 
> > Why is mfg using <&clk26m> and not <&topckgen CLK_TOP_MFG_SEL>?
> 
> Because James Liao said to me that it is derived from clk26m and not
> from mfg_sel.

Sascha is right. I had confirmed with our designer that MFG on MT8173
uses clk26m to check state. I also tested MFG domain power on/off with
CLK_TOP_MFG_SEL off and it worked correctly.

> > I saw another patch set on the list today from James Liao that adds more clocks.
> > Perhaps we can move the SCPSYS set on top of that one and include more clocks?
> > 
> > > +                                <&topckgen CLK_TOP_MM_SEL>;

The clocks used by scpsys driver are subsystem bus clocks that need to
be on before power on these domains. On MT8173, subsystem bus clocks are
come from topckgen.

My patch set yesterday add subsystem clocks, which are not needed by
power domain on/off. So I think these 2 patch set are independent.


Best regards,

James