* [PATCH v2 1/2] ARM: dts: sun7i: Add uart4_pins_b definition @ 2015-05-22 14:33 Hans de Goede [not found] ` <1432305184-8589-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Hans de Goede @ 2015-05-22 14:33 UTC (permalink / raw) To: Maxime Ripard Cc: Michael Ring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Hans de Goede From: Michael Ring <mail-u1jPNj63thkWnkcawLe0jA@public.gmane.org> Some boards (e.g. the BananaPro) use alternative pins for uart4, add a pinmux entry for these. Signed-off-by: Michael Ring <mail-u1jPNj63thkWnkcawLe0jA@public.gmane.org> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> --- arch/arm/boot/dts/sun7i-a20.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index e04cdf9..99d48b4 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -844,6 +844,13 @@ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; }; + uart4_pins_b: uart4@1 { + allwinner,pins = "PH4", "PH5"; + allwinner,function = "uart4"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; + }; + uart5_pins_a: uart5@0 { allwinner,pins = "PI10", "PI11"; allwinner,function = "uart5"; -- 2.4.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1432305184-8589-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* [PATCH v2 2/2] ARM: dts: sun7i: Add uart4 support for BananaPro, disable uart2 [not found] ` <1432305184-8589-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2015-05-22 14:33 ` Hans de Goede [not found] ` <1432305184-8589-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Hans de Goede @ 2015-05-22 14:33 UTC (permalink / raw) To: Maxime Ripard Cc: Michael Ring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Hans de Goede From: Michael Ring <mail-u1jPNj63thkWnkcawLe0jA@public.gmane.org> The BananaPro uses uart4 for the default rx/tx pins on the 40 pins connector, so enable uart4. Uart2 is also available at the bananapro io-pins, but like on the bananapi the primary function of the pins is to act as gpios, see: http://forum.lemaker.org/forum.php?mod=viewthread&tid=10852 Remove the uart2 node, people who want to use uart2 can do so with a devicetree-overlay. Signed-off-by: Michael Ring <mail-u1jPNj63thkWnkcawLe0jA@public.gmane.org> [hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org: Remove uart2 node] Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> --- Changes in v2: -Remove uart2 node instead of disabling it --- arch/arm/boot/dts/sun7i-a20-bananapro.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts index 45e2a02..18fcc87 100644 --- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts @@ -52,7 +52,7 @@ aliases { serial0 = &uart0; - serial1 = &uart2; + serial1 = &uart4; serial2 = &uart7; }; @@ -250,9 +250,9 @@ status = "okay"; }; -&uart2 { +&uart4 { pinctrl-names = "default"; - pinctrl-0 = <&uart2_pins_a>; + pinctrl-0 = <&uart4_pins_b>; status = "okay"; }; -- 2.4.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1432305184-8589-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH v2 2/2] ARM: dts: sun7i: Add uart4 support for BananaPro, disable uart2 [not found] ` <1432305184-8589-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2015-05-22 19:24 ` Maxime Ripard 0 siblings, 0 replies; 3+ messages in thread From: Maxime Ripard @ 2015-05-22 19:24 UTC (permalink / raw) To: Hans de Goede Cc: Michael Ring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 903 bytes --] On Fri, May 22, 2015 at 04:33:04PM +0200, Hans de Goede wrote: > From: Michael Ring <mail-u1jPNj63thkWnkcawLe0jA@public.gmane.org> > > The BananaPro uses uart4 for the default rx/tx pins on the 40 pins connector, > so enable uart4. > > Uart2 is also available at the bananapro io-pins, but like on the bananapi > the primary function of the pins is to act as gpios, see: > http://forum.lemaker.org/forum.php?mod=viewthread&tid=10852 > > Remove the uart2 node, people who want to use uart2 can do so with a > devicetree-overlay. > > Signed-off-by: Michael Ring <mail-u1jPNj63thkWnkcawLe0jA@public.gmane.org> > [hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org: Remove uart2 node] > Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Applied both, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-22 19:24 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-22 14:33 [PATCH v2 1/2] ARM: dts: sun7i: Add uart4_pins_b definition Hans de Goede [not found] ` <1432305184-8589-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-05-22 14:33 ` [PATCH v2 2/2] ARM: dts: sun7i: Add uart4 support for BananaPro, disable uart2 Hans de Goede [not found] ` <1432305184-8589-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-05-22 19:24 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).